fix(alerts): return 400 instead of 500 when creating alert with unsupported dataset#119456
Draft
billyvg wants to merge 1 commit into
Draft
fix(alerts): return 400 instead of 500 when creating alert with unsupported dataset#119456billyvg wants to merge 1 commit into
billyvg wants to merge 1 commit into
Conversation
…ported dataset
When a user POSTs to /api/0/organizations/{org}/alert-rules/ with
`dataset=sessions` (or any dataset not in `query_datasets_to_type`),
the lookup `query_datasets_to_type[dataset]` raises a KeyError that
bubbles up as an unhandled 500. Add an explicit ValidationError before
the dict lookup so callers get a well-formed 400 with a helpful message
listing the valid datasets.
Fixes SENTRY-5PEF
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LjN9gb92hUE6jTqQ9dkjAm
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SENTRY-5PEF —
KeyError: <Dataset.Sessions: 'sessions'>insnuba_query_validator.pyRoot cause: When a user POSTs to
/api/0/organizations/{org}/alert-rules/withdataset=sessions(or any dataset absent fromquery_datasets_to_type), the dict lookup on line 321 raises an unhandledKeyErrorthat propagates as a 500.Dataset.Sessionswas removed fromquery_datasets_to_type(which now only containsEvents,Transactions,PerformanceMetrics,Metrics, andEventsAnalyticsPlatform), but external API clients still senddataset=sessions. This has been happening since at least 2026-05-06 with 8 unique users affected.Fix: Add an explicit
dataset not in query_datasets_to_typecheck that raises aserializers.ValidationError(→ HTTP 400) with a message listing the valid datasets, before the dict lookup that was previously crashing.Evidence:
sentry/snuba/snuba_query_validator.py:321in_validate_query—query_datasets_to_type[dataset]raisesKeyErrorwhen dataset isDataset.SessionsTest plan
test_invalid_dataset_sessions_returns_validation_errortotests/sentry/snuba/test_validators.pycovering the exact failing caseSnubaQueryValidatorTesttests continue to passClaude session: https://claude.ai/code/session_01LjN9gb92hUE6jTqQ9dkjAm
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Generated by Claude Code