fix(performance-detection): handle missing 'description' key in MN+1 DB span detector#119450
Draft
billyvg wants to merge 1 commit into
Draft
fix(performance-detection): handle missing 'description' key in MN+1 DB span detector#119450billyvg wants to merge 1 commit into
billyvg wants to merge 1 commit into
Conversation
…DB span detector Fixes SENTRY-5QVD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
KeyError: 'description'crash (SENTRY-5QVD) that occurs in the MN+1 DB span detector when a DB span is missing thedescriptionfield.Problem
In
mn_plus_one_db_span_detector.py, the_maybe_performance_problemmethod accesseddb_span["description"]in two places (lines 258 and 283), raising aKeyErrorwhenever a span arrives without that field. This was generating 212k+ error events in production (sentry regionus, consumerprocess-segments).Seer's analysis confirmed: "Use
.get('description', '')to safely access the db span description."Fix
Replace
db_span["description"]withdb_span.get("description", "")in both call sites:desc=parameter ofPerformanceProblem()get_notification_attachment_body()call inevidence_displayThis is safe because an empty string is the appropriate fallback for a missing description — no performance problem is skipped and no fingerprint logic is affected (the fingerprint uses
db_span["hash"], not description).Evidence
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Generated by Claude Code