fix(members): Ignore detail responses in member cache scan#115618
Closed
scttcper wants to merge 1 commit into
Closed
fix(members): Ignore detail responses in member cache scan#115618scttcper wants to merge 1 commit into
scttcper wants to merge 1 commit into
Conversation
The member cache scan matched any /members/ or /users/ prefix, so cached detail responses could get treated like member arrays and blow up during render. Limit the scan to the list endpoints and skip non-array payloads. Adds a regression test that seeds a cached user detail response first. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.52% |
Member
Author
|
not the right solution see #115619 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#115554 added a cache scan for member lookups, but it matched any
/members/or/users/prefix. That meant cached detail responses like/organizations/:org/users/:id/could get treated like member arrays and crash on.filter().This keeps the scan to the list endpoints and skips non-array payloads, so the avatar fallback still reuses cached member lists without blowing up on detail cache entries.
fixes JAVASCRIPT-39P3