o11y(preprod): Add context to snapshot status check and PR comment logs#115612
Open
NicoHinderling wants to merge 2 commits into
Open
o11y(preprod): Add context to snapshot status check and PR comment logs#115612NicoHinderling wants to merge 2 commits into
NicoHinderling wants to merge 2 commits into
Conversation
The success log for posting GitHub status checks only included artifact and check IDs. Add status, subtitle, repo, and sha to help diagnose cases where a status check post succeeds but GitHub doesn't reflect the expected state. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
Add repo_name, pr_number, and is_update to the success log for posting snapshot PR comments, matching the status check logging improvement. Co-Authored-By: Claude <noreply@anthropic.com>
NicoHinderling
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add structured log fields to the success events for both snapshot
status check posts and PR comment posts.
When a user reports that their GitHub status check or PR comment
wasn't updated, we can see the post succeeded but have no way to
tell what was posted. These fields close that gap without
introducing high-cardinality metric tags (log extras only).
Status checks (
preprod.snapshot_status_checks.post.success):adds
status,subtitle,repo,shaPR comments (
preprod.snapshot_pr_comments.post.success):adds
repo_name,pr_number,is_update