ref(repositories): Remove feature flag branching for RepositoryProjectPathConfig reads#115607
Open
wedamija wants to merge 4 commits into
Open
ref(repositories): Remove feature flag branching for RepositoryProjectPathConfig reads#115607wedamija wants to merge 4 commits into
wedamija wants to merge 4 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
wedamija
force-pushed
the
danf/repo-remove-codemappings-branch
branch
from
2ade591 to
734fb98
Compare
scttcper
approved these changes
May 14, 2026
…tPathConfig reads Remove the `organizations:project-repository-fk-reads` flag checks from all RepositoryProjectPathConfig read paths. Always use `project_repository` FK for queries and attribute access. The flag registration is left in place — it will be removed in a follow-up PR that also drops the old model columns. Switched paths: - Code mappings list/validate/create API - Code mapping serializer - Code mapping details/delete endpoints - Code mapping codeowners endpoint - Stacktrace link resolution - Source context fetching - Commit context / suspect commits - Code owners auto-sync - Project code owners serializer - get_sorted_code_mapping_configs - Autopilot missing SDK integration detector - Project transfer_to cleanup
wedamija
force-pushed
the
danf/repo-remove-codemappings-branch
branch
from
ea63f2c to
e2f0cc9
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e2f0cc9. Configure here.
| assert ( | ||
| SeerProjectRepository.objects.filter( | ||
| project=self.proj, project_repository_id__isnull=True | ||
| project_repository__project=self.proj, project_repository_id__isnull=True |
Contributor
There was a problem hiding this comment.
Migration test assertions become vacuous no-ops
Medium Severity
The setup_before_migration now pre-creates all ProjectRepository rows and sets project_repository=pr_a (etc.) on every record before the migration runs, so the migration has nothing to backfill. Additionally, the null-check assertions at lines 174–187 filter with project_repository__project=self.proj, project_repository_id__isnull=True — Django's inner join semantics mean rows with a null FK are excluded by the join, so the count is always 0 regardless of data state. The test no longer validates the migration's actual backfill logic.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e2f0cc9. Configure here.
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
organizations:project-repository-fk-readsflag checks from all RepositoryProjectPathConfig read paths. Always useproject_repositoryFK for queries and attribute access.For now we'll keep
organizations:project-repository-fk-readsaround, since we'll have a separate pr to remove reads/writes for code mappings.Seer removals: #115606