fix(replays): make link copy button accessible and non-variable width#115598
Open
JoshuaKGoldberg wants to merge 1 commit into
Open
fix(replays): make link copy button accessible and non-variable width#115598JoshuaKGoldberg wants to merge 1 commit into
JoshuaKGoldberg wants to merge 1 commit into
Conversation
JoshuaKGoldberg
changed the title
github-actions
Bot
added
the
Scope: Frontend
JoshuaKGoldberg
commented
May 14, 2026
| height: 34px; | ||
| `; | ||
|
|
||
| const HoverArea = styled(Flex)``; |
Member
Author
There was a problem hiding this comment.
[Question] Do we, have a better way of doing this? Note the need to ${HoverArea} a few lines later.
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.52% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues with the replay link copy button:
focus-withinfor its hover presence so non-mouse (e.g. keyboard) users can see itAlso removes an extra
<Flex>container around the flex container.