ref(seer): simplify block component states#115589
Draft
natemoo-re wants to merge 6 commits into
Draft
Conversation
Replace the legacy MarkedText (dangerouslySetInnerHTML-based) renderer with the new token-based Markdown component from @sentry/scraps. This enables streaming decode animations for active assistant blocks and component-level customization via the components prop. - Swap MarkedText for Markdown across all block content (assistant, thinking, disclosure, and todo list) - Remove the onClick link handler from AssistantBlock since Markdown's DefaultLink already handles internal/external routing - Move issue short ID linkification from string preprocessing (postProcessLLMMarkdown) to a Markdown Text component override, which naturally excludes code blocks, links, and URLs via tokenization - Delete postProcessLLMMarkdown, linkifyIssueShortIds, and their tests - Remove useBlockContent hook (inlined into AssistantBlock) - Set variant="streaming" on the active assistant block's Markdown Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Remove MarkdownContent and TodoListContent styled wrappers that were leftover from the MarkedText migration. The Markdown component's default components already handle inline code, tables, lists, and horizontal rules. - Add overflowWrap: break-word to core Markdown component - Export MarkdownProps from the core markdown barrel - Add SeerMarkdown passthrough with custom Heading (size="lg" for all levels) and IssueIdText overrides - Replace TodoListContent styled wrapper with Text primitive Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Replace todosToMarkdown string serialization with a TodoList component that renders TodoItem[] directly as React elements. This avoids converting structured data to markdown just to parse it back into the same component tree. Uses Checkbox, Flex, and Stack primitives matching the core Markdown DefaultTaskList/DefaultTaskListItem patterns. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introduced
This is informational only and does not block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete overhaul of the
static/app/views/seerExplorer/components/blockComponents.tsxfile that