feat(logs): Wire Seer AI visualization params into logs explore#115585
Draft
isaacwang-sentry wants to merge 1 commit into
Draft
feat(logs): Wire Seer AI visualization params into logs explore#115585isaacwang-sentry wants to merge 1 commit into
isaacwang-sentry wants to merge 1 commit into
Conversation
ecd9e6b to
c6d8bea
Compare
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.52% |
Extract reusable helpers (getLogsSeerLocationQuery, getLogsSeerAggregateFields) from the LogsTabSeerComboBox component so the Seer-to-URL wiring is testable and decoupled from the React component. Add support for Seer returning visualization payloads (chart type + y-axes) and propagate them into the aggregate field and sort query params. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
c6d8bea to
a1d6489
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getLogsSeerLocationQueryandgetLogsSeerAggregateFieldsfrom theLogsTabSeerComboBoxcomponent into testable, reusable helpersTest plan
getLogsSeerLocationQuerycovering samples mode, aggregate mode, group-by ordering, and fallback when Seer omits visualizations