ref(seer): Unify explorer state with shared context and fix optimistic updates

[JonasBa]

Centralizes active run id logic inside the seer context allowing us to remove the hook sync mechanism.

sequenceDiagram
    participant U as User
    participant L as Local State<br/>(reducer + sessionStorage)
    participant S as Server<br/>(query cache)

    Note over L: Init: sessionStorage → reducer seed

    rect rgb(240, 240, 255)
    Note over U,S: Page load
    S->>S: useQuery /explorer-runs/
    S-->>L: ExplorerSession[]
    L->>L: merge: sessions.map(s => {…s, status: reducer[s.id] ?? idle})
    L-->>U: {query, conversations}
    end

    rect rgb(240, 255, 240)
    Note over U,S: Switch to existing run
    U->>L: dispatch('set active run', 123)
    L->>L: reducer marks 123 active, rest idle
    L-->>L: write-through → sessionStorage
    L->>L: re-merge with existing query data
    L-->>U: runId = 123
    end

    rect rgb(255, 245, 235)
    Note over U,S: New conversation
    U->>S: POST /explorer-chat/ {query}
    S-->>L: onSuccess → {run_id: 456}
    L->>L: ① dispatch('set active run', 456)
    L-->>L: write-through → sessionStorage
    L->>S: ② setApiQueryData: prepend new session to cache
    Note over L: merge runs — new session appears<br/>with status: active in one render
    L-->>U: runId = 456, conversation visible
    end

Loading

[github-actions]

📊 Type Coverage Diff

Metric	Before	After	Delta
Coverage	93.52%	93.52%	±0%
Typed	135,612	135,625	🟢 +13
Untyped	9,398	9,395	🟢 -3

🔍 1 new type safety issue introduced

any-typed symbols (1 new)

File	Line	Detail
static/app/views/seerExplorer/seerExplorerSessionContext.tsx	156	parsed (var)

This is informational only and does not block the PR.

[sentry]

Bug: The 'set active run' reducer fails to add a new conversation's run_id to the state because it only updates runs that already exist, preventing new conversations from being marked as active.
_{Severity: HIGH}

Suggested Fix

Modify the 'set active run' reducer to handle cases where the run_id does not yet exist in the state. If next[action.payload] is falsy, create a new entry for the run and set it as active. This will ensure that newly created conversations are correctly added to the state and marked as the active conversation.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: static/app/views/seerExplorer/seerExplorerStateContext.tsx#L22-L24

Potential issue: When a new conversation is created in the Seer Explorer, the 'set
active run' action is dispatched. The corresponding reducer attempts to update the
state, but it only modifies entries that already exist. For a new conversation, its
`run_id` is not yet present in the state object. The condition `if
(next[action.payload])` evaluates to false, causing the reducer to do nothing.
Consequently, the new run is never added to the state or marked as active, and the
derived `runId` remains `null`, breaking the user flow for creating new conversations.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[cursor]

Repeated active run derivation across three files

Low Severity

The expression conversations.find(c => c.status === 'active')?.run_id ?? null is duplicated identically in topBar.tsx, useSeerExplorer.tsx, and useSeerExplorerContext.tsx. Since the conversations memo in the provider already computes activeId internally, exposing it as part of the context value (or as a small helper) would eliminate the redundancy and reduce the risk of these three sites drifting apart if the active-run logic changes.

Additional Locations (2)

• static/app/views/navigation/topBar.tsx#L43-L45
• static/app/views/seerExplorer/useSeerExplorerContext.tsx#L41-L43

 

^{Reviewed by Cursor Bugbot for commit 9baff31. Configure here.}

[JonasBa]

This is ok.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 9685060. Configure here.}

[cursor]

Duplicated active run derivation across three files

Low Severity

The expression conversations.find(c => c.status === 'active')?.run_id ?? null is duplicated in three separate files (topBar.tsx, useSeerExplorer.tsx, useSeerExplorerContext.tsx). Since the PR specifically centralizes session state into SeerExplorerSessionsProvider, the active run ID could be computed once inside the provider and exposed alongside conversations in the context value, eliminating the repeated derivation.

Additional Locations (2)

• static/app/views/seerExplorer/hooks/useSeerExplorer.tsx#L150-L151
• static/app/views/navigation/topBar.tsx#L43-L45

 

^{Reviewed by Cursor Bugbot for commit 9685060. Configure here.}