fix(alerts): Return 400 when trigger IDs don't belong to the alert rule being updated#115573
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
saponifi3d
approved these changes
May 14, 2026
| missing_ids = [tid for tid in trigger_ids if tid not in existing_trigger_ids] | ||
| if missing_ids: | ||
| raise serializers.ValidationError( | ||
| f"Trigger IDs do not belong to this alert rule: {missing_ids}" |
Contributor
There was a problem hiding this comment.
super nit: this error message would scare me quite a lot if i were a user; wonder if it could be something like Alert Trigger IDs are not valid: {missing_ids} -- the whole not belonging makes it feel like there could be a security problem or something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's deprecated code, but it'll be around for months yet, so better to fail more helpfully if we can.
Fixes SENTRY-5NJ6