feat(explore): heat map tooltip surfaces z-axis value alongside y-axis bucket#115560
Conversation
github-actions
Bot
added
the
Scope: Frontend
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.52% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ); | ||
|
|
||
| if (serie.seriesType === 'heatmap') { | ||
| const zAxisCountValue = getSeriesValue(serie, 2).toString(); |
There was a problem hiding this comment.
Tooltip shows log-transformed z-value instead of original count
Medium Severity
When scale is 'log', toSeries stores Math.log1p(zValue) at data index 2. The tooltip reads this transformed value via getSeriesValue(serie, 2) and displays it directly. Users see a meaningless logarithmic number (e.g., 6.91) instead of the actual count (e.g., 1000). The tooltip needs to reverse the transformation (via Math.expm1) or access the original value.
Reviewed by Cursor Bugbot for commit 602c176. Configure here.
There was a problem hiding this comment.
not needed because the log scaling is only for the y-axis
nikkikapadia
changed the title
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e032dc7. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| <HeatMapWidgetVisualization plottables={[new HeatMap(sampleLatencyHeatMap)]} /> | ||
| </LargeWidget> | ||
| <p> | ||
| <strong>Hint:</strong> clicking on the chart will display the x-, y-, and z-axis |
There was a problem hiding this comment.
Fun fact: I was unsure if grammatically it should be "x-, y-, and z-axis" vs "x, y, and z-axis", so I searched it. Turns out it's called suspended hyphen, TIL!
There was a problem hiding this comment.
omg wow i just guessed 🎉
2 participants
I've changed the tooltip for heat maps to use the y-axis time bucket and the z-axis value side by side. I've also gotten rid of the marker and series name on the tooltip because they're not needed for heat maps. Here's what it looks like:
must be merged after #115413