fix(seer): Restore automated Explorer handoffs#115559
Draft
JoshFerge wants to merge 3 commits into
Draft
Conversation
github-actions
Bot
added
the
Scope: Backend
Member
Author
|
bugbot run |
Member
Author
|
@sentry review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 36665a3. Configure here.
JoshFerge
force-pushed
the
jferg-codex/explorer-automation-stopping-point
branch
from
36665a3 to
b56393c
Compare
JoshFerge
changed the title
Add focused AutofixOnCompletionHook coverage for the Explorer automation branch that either triggers an external coding-agent handoff or continues to solution based on project handoff configuration. Also lock down that a configured handoff is skipped when stopping_point metadata is missing, which documents the bug fixed by the stopping-point change. Co-Authored-By: Codex <noreply@openai.com>
Projects can have external automation handoff configured while their automated stopping point is root_cause. The completion hook treated root cause as terminal before consulting handoff config, so those runs never launched the configured coding agent. Check handoff first and cover that state in tests. Co-Authored-By: Codex <noreply@openai.com>
JoshFerge
force-pushed
the
jferg-codex/explorer-automation-stopping-point
branch
from
2c5f358 to
fa7c4a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Explorer-backed automated Autofix relies on
AutofixOnCompletionHookin Sentry to continue after each Seer step. That hook needsstopping_pointmetadata to distinguish automated runs from manual runs; without it, non-seat-based Explorer automation can finish root cause and return without continuing or handing off.The production shape also shows many projects with external
automation_handoffconfigured while their stored automated stopping point isroot_cause. That combination is valid for the old handoff setup: Seer should stop its own work at root cause and hand the issue to the configured coding agent. The hook previously checked "we reached root cause" before checking handoff config, so those projects were treated as terminal and never launched the agent.Together this explains why downstream Autofix steps can stay healthy globally while coding-agent handoffs are low: unconfigured projects keep continuing through Seer, but configured root-cause handoff projects exit before handoff.
Summary