fix(ourlogs): use replaceMerge for time series visualization axes#115551
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.52% |
JoshuaKGoldberg
commented
May 14, 2026
JoshuaKGoldberg
changed the title
replaceMerge for time series visualization axes
gggritso
approved these changes
May 14, 2026
nsdeschenes
approved these changes
May 15, 2026
k-fish
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#113434 made merging more automatic/seamless for the time series charts by disabling
notMerge. Unfortunately, a side effect of that was ECharts auto-computing the x-axis range from combined (merged) series data. Going from a large range like 24h to a small one like 1h kept the 24h range in the x-axis.This uses EChart's
replaceMerge(shoutout @k-fish for pointing me there) to recompute on x-axis and y-axis changes.Aside: in the initial investigation I spent 15 minutes poking through code while Claude investigated. I didn't figure it out, but Claude did. rip.
Fixes LOGS-802.