Skip to content

chore: merged Jest changedSince testing into main PR Jest job#115549

Merged
JoshuaKGoldberg merged 5 commits into
masterfrom
jest-changedSince-for-all
May 19, 2026
Merged

chore: merged Jest changedSince testing into main PR Jest job#115549
JoshuaKGoldberg merged 5 commits into
masterfrom
jest-changedSince-for-all

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 14, 2026

#110568 (ENG-7103) added an optional, non-blocking CI job that runs Jest with --changedSince <merge_base>. It's been stable (per data crunching in ENG-7687), so this graduates it into the required frontend-jest-tests job. That means we'll only be running one Jest job per PR:

  • If merge_base can be computed, Jest will run with --changedSince (this is the common flow for most frontend-code-only PRs)
  • Otherwise, we'll run all Jest tests to be safe (the behavior before, in particular for when any config file changes)

This actually removes frontend-optional.yml altogether. The Jest tests were the only things running in it as of #115504. 🔪

Fixes ENG-7688.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 14, 2026
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 14, 2026

ENG-7688

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.56%

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 14, 2026 13:40
@JoshuaKGoldberg JoshuaKGoldberg requested review from a team as code owners May 14, 2026 13:40
Comment thread .github/workflows/frontend.yml
Comment thread .github/workflows/frontend.yml
Prevents MERGE_BASE from being set when a merge commit lands on master,
which would cause jest --changedSince to fail in the shallow-cloned jest job.
Comment thread .github/workflows/frontend-optional.yml
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8b4dbaa. Configure here.

Comment thread .github/workflows/frontend-optional.yml Outdated
@JoshuaKGoldberg JoshuaKGoldberg requested a review from scttcper May 14, 2026 16:36
@JoshuaKGoldberg JoshuaKGoldberg merged commit 48df634 into master May 19, 2026
69 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the jest-changedSince-for-all branch May 19, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants