chore: merged Jest changedSince testing into main PR Jest job#115549
Merged
Conversation
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.56% |
scttcper
approved these changes
May 14, 2026
Prevents MERGE_BASE from being set when a merge commit lands on master, which would cause jest --changedSince to fail in the shallow-cloned jest job.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8b4dbaa. Configure here.
scttcper
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

#110568 (ENG-7103) added an optional, non-blocking CI job that runs Jest with
--changedSince <merge_base>. It's been stable (per data crunching in ENG-7687), so this graduates it into the requiredfrontend-jest-testsjob. That means we'll only be running one Jest job per PR:merge_basecan be computed, Jest will run with--changedSince(this is the common flow for most frontend-code-only PRs)This actually removes
frontend-optional.ymlaltogether. The Jest tests were the only things running in it as of #115504. 🔪Fixes ENG-7688.