fix(workflows): Correctly convert boolean filter values for Snuba queries#115532
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(workflows): Correctly convert boolean filter values for Snuba queries#115532sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
QueryExecutionErrororiginating from ClickHouse when evaluating workflow alert conditions that include filters likeerror.handled = false.Root Cause:
The
convert_filter_to_snuba_conditionfunction insentry/workflow_engine/handlers/condition/event_frequency_query_handlers.pywas passing the string literal'false'directly to Snuba for theerror.handledattribute. This attribute maps to theexception_stacks.mechanism_handledcolumn in ClickHouse, which is of typeUInt8. ClickHouse cannot implicitly convert the string'false'to aUInt8, leading to a type conversion error.Additionally, a subtle bug was identified in the handling of
error.unhandled. The expressionnot condition["value"](wherecondition["value"]could be the string'false') would incorrectly evaluate toFalsebecause any non-empty string is truthy in Python. This meant that a filter forerror.unhandled = falsewas being translated tohandled = Falseinstead of the semantically correcthandled = True.Fix:
The logic for both
error.handledanderror.unhandledwithinconvert_filter_to_snuba_conditionhas been updated and consolidated. It now correctly parses the string value ('true'or'false') from the condition into a Python boolean (TrueorFalse) before constructing the Snuba query. This ensures that ClickHouse receives a compatible boolean/integer type for theUInt8column, resolving the type conversion error and correctly interpreting theerror.unhandledfilter.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5PE8