fix(replays): Use Spans dataset when fetching contents of "Trace" tab#115530
Open
gggritso wants to merge 5 commits into
Open
fix(replays): Use Spans dataset when fetching contents of "Trace" tab#115530gggritso wants to merge 5 commits into
gggritso wants to merge 5 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.52% |
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…ilable The old sorting logic subtracted max(transaction.duration) from the min timestamp to estimate trace start time. After switching to the Spans dataset, max(precise.finish_ts) is a Unix timestamp—not a duration—so the arithmetic was incorrect. Since min(precise.start_ts) already gives the earliest start time directly, sort by that value and drop the unused max(precise.finish_ts) field from the query.
Member
Author
|
@cursor review |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 12a8ac4. Configure here.
…find-any-trace-tab-contents-with-streaming
nsdeschenes
approved these changes
May 14, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
EventView expects the alias format (min_precise_start_ts) rather than the function format (min(precise.start_ts)) for the orderby parameter. The function format was silently dropped from the API request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK team found in REPLAY-915 that the "Trace" tab of a Replay never loads anything when a streaming SDK is used. This is because that tab us implicitly using the "Discover" (i.e., Transactions) dataset, and the transaction dataset fields.
This PR updates the fetch request to use the "spans" dataset. That dataset doesn't support the
min()function on thetimestampfield nor themax()function on thetransaction.durationfield, so I updated them both to use the precise timestamp field instead. That also makes the hack that subtracts the duration from the timestamp irrelevant, since we can explicitly ask for min start and max finish.Closes REPLAY-915.