chore(migrations): Delete migration tests over a week old#115528
Draft
JoshFerge wants to merge 1 commit into
Draft
chore(migrations): Delete migration tests over a week old#115528JoshFerge wants to merge 1 commit into
JoshFerge wants to merge 1 commit into
Conversation
Migration tests only verify the one-time migration logic. Once a migration has been deployed (more than a week ago), the test no longer provides value. Keeps tests for migrations added within the last week. Agent transcript: https://claudescope.sentry.dev/share/aFldkPeJaa4Ir6fSec9SSew5EiVG6pS7dbU8OPAISZc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migration tests verify one-time backfill/data-fix logic. Once a migration has been deployed for more than a week, the test no longer provides meaningful coverage — it just adds CI time and maintenance overhead.
This deletes 37 migration tests whose corresponding migrations were added more than 7 days ago (as of 2026-05-13). Kept the two recent ones:
tests/sentry/migrations/test_1092_backfill_projectrepository.py(added today)tests/sentry/workflow_engine/migrations/test_0113_migrate_data_conditions_categories.py(added 2026-05-06)tests/sentry/migrations/test_noop.py(not a real migration test)Two of the deleted tests (
test_0002_backfill_insights_team_starred_segments.py,test_0078_update_metric_detector_config_fields.py) were already stale — their migration files no longer exist.Test plan