feat(issues): Implement UI for new Seer actions included in issue activity#115525
feat(issues): Implement UI for new Seer actions included in issue activity#115525shashjar wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
|
|
||
| {group.activity.map(item => { | ||
| const authorName = item.user ? item.user.name : 'Sentry'; | ||
| {group.activity |
There was a problem hiding this comment.
idk why the diff in this file is so bad - use Hide whitespace to review
There was a problem hiding this comment.
thanks for calling this out! 🙏
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.51% |
| }; | ||
| case GroupActivityType.SEER_RCA_STARTED: | ||
| return { | ||
| title: t('Root Cause Analysis'), |
There was a problem hiding this comment.
Open to thoughts on the text/detail/metadata provided in each of these activity types - definitely something we can/will iterate on
There was a problem hiding this comment.
👍 i think for now these all seem great, agree that this is a simple update if we want in the future.
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
really just nitpicks and small things we could clean-up; it'd be nice if we can determine if seer can support a normalized data payload for this / future PRs.
| type: GroupActivityType.SEER_CODING_COMPLETED; | ||
| } | ||
|
|
||
| interface GroupActivitySeerPrCreated extends GroupActivityBase { |
There was a problem hiding this comment.
if we end up normalizing this in seer, then we can probably make a GroupSeerActivity or something to handle all of these 🎉
let's try to determine if we can normalize everything from seer asap so we can clean this / the activity code up, and before it proliferates too much.
| }; | ||
| case GroupActivityType.SEER_RCA_STARTED: | ||
| return { | ||
| title: t('Root Cause Analysis'), |
There was a problem hiding this comment.
👍 i think for now these all seem great, agree that this is a simple update if we want in the future.
| }, | ||
| }, | ||
| [GroupActivityType.DELETED_ATTACHMENT]: {Component: IconDelete, defaultProps: {}}, | ||
| [GroupActivityType.SEER_RCA_STARTED]: {Component: IconSeer, defaultProps: {}}, |
There was a problem hiding this comment.
Thoughts on adding the animation="waiting" prop for the STARTED actions?
| [GroupActivityType.SEER_SOLUTION_STARTED]: {Component: IconSeer, defaultProps: {}}, | ||
| [GroupActivityType.SEER_SOLUTION_COMPLETED]: {Component: IconSeer, defaultProps: {}}, | ||
| [GroupActivityType.SEER_CODING_STARTED]: {Component: IconSeer, defaultProps: {}}, | ||
| [GroupActivityType.SEER_CODING_COMPLETED]: {Component: IconSeer, defaultProps: {}}, |
There was a problem hiding this comment.
thoughts on using the accent variant for completed? so we can see it in sentry purple -- or maybe success to see it in green?
|
|
||
| {group.activity.map(item => { | ||
| const authorName = item.user ? item.user.name : 'Sentry'; | ||
| {group.activity |
There was a problem hiding this comment.
thanks for calling this out! 🙏
| {group.activity | ||
| .filter( | ||
| item => | ||
| !SEER_ACTIVITY_TYPES.has(item.type) || | ||
| organization.features.includes('seer-activity-timeline') | ||
| ) |
There was a problem hiding this comment.
nit: i'd recommend pulling this out of the render logic and make it a const, visible_activities or something like that. just helps with readability.
| return t('Seer completed implementing a fix'); | ||
| case GroupActivityType.SEER_PR_CREATED: { | ||
| const {data: prData} = activity; | ||
| const pr = prData.pull_requests?.[0]; |
There was a problem hiding this comment.
i think we'd probably want to show the links for all of these; maybe this could just iterate and build a ul of PRs for review?
if we can get the PR title, maybe we say something like:
▲ Seer Opened Pull Requests
| case GroupActivityType.SEER_RCA_COMPLETED: | ||
| return t('Seer completed root cause analysis'); | ||
| case GroupActivityType.SEER_SOLUTION_STARTED: | ||
| return t('Seer started developing a solution'); | ||
| case GroupActivityType.SEER_SOLUTION_COMPLETED: | ||
| return t('Seer completed developing a solution'); |
There was a problem hiding this comment.
this file only appears on the feedback page we likely don't need to bother here
3 participants
Resolves ID-1527.
Follow-up to #115486.
Adds 7 new
GroupActivityTypeenum values for Seer pipeline stages, to match the backend updates previously made in the above PR. These Seer actions are then rendered as part of issue activity in both the classic and streamlined issue detail views (usingIconSeer).Gated behind an organization-level feature flag for initial rollout:
organizations:seer-activity-timeline.