feat(issues): Color activity timeline connectors by issue status#115518
Draft
scttcper wants to merge 1 commit into
Draft
feat(issues): Color activity timeline connectors by issue status#115518scttcper wants to merge 1 commit into
scttcper wants to merge 1 commit into
Conversation
Adds colored connector lines and icon borders to the activity timeline in the drawer view. A state machine walks the activity history to reconstruct the issue's status at each point, then colors connectors based on the status during the interval between events (red for unresolved, green for resolved, yellow for new, gray for ignored/neutral). The timeline component gets connectorColor and iconBorderColor props, using a CSS custom property to layer colored segments over the existing neutral line. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
Member
|
This is cool. The status information at various points in time is pretty easy for us to derive from the issue action log, so there may be a case for using it do this sort of thing, but the practicality of that depends on some other specifics of how we integrate with the activity view that I'm not sure of yet. For relatively small activity feeds or suitably filtered, we can just run the processing; for the outlier cases it may involve checkpointing, reverse processing, or fully-derived activity view stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds colored connector lines and icon borders to the activity timeline in the drawer view. A state machine walks the activity history to reconstruct the issue's status at each point in time, then colors connectors based on the status during the interval between events - red for unresolved, green for resolved, yellow for new, gray for ignored/neutral.
The timeline component gets
connectorColorandiconBorderColorprops, using a CSS custom property (--timeline-connector-color) to layer colored segments over the existing neutral connector line. Only computed whenisDraweris true.