ref(seer): Extract explorer sessions into a shared React context#115515
ref(seer): Extract explorer sessions into a shared React context#115515JonasBa wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.51% |
JonasBa
force-pushed
the
jb/seer/sessions-context
branch
from
38af97f to
1b6a7e5
Compare
github-actions
Bot
added
the
Scope: Backend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
JonasBa
force-pushed
the
jb/seer/sessions-context
branch
from
1b6a7e5 to
ce0246c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 50534fc. Configure here.
| import {isSeerExplorerEnabled} from 'sentry/views/seerExplorer/utils'; | ||
|
|
||
| function useSeerExplorerSessionsQuery({ | ||
| limit = 10, |
There was a problem hiding this comment.
Default session limit reduced from 20 to 10
Low Severity
The default limit parameter in useSeerExplorerSessionsQuery is 10, reduced from the previous value of 20 used in the deleted useExplorerSessions hook. The SeerExplorerSessionsProvider currently overrides this with limit: 20, so runtime behavior is preserved. However, the misleading default could cause a regression if the function is ever called without an explicit limit. As noted in the PR discussion, this reduction was not intentional.
Reviewed by Cursor Bugbot for commit 50534fc. Configure here.
2 participants
Replace useExplorerSessions with a dedicated top level provider. This makes sessions and history app wide, opens the door for parallel chats and different improvement in the future.