Skip to content

ref(ds): Remove reservoir sampling rule#115365

Open
Dav1dde wants to merge 8 commits into
masterfrom
dav1d/rm-reservoir
Open

ref(ds): Remove reservoir sampling rule#115365
Dav1dde wants to merge 8 commits into
masterfrom
dav1d/rm-reservoir

Conversation

@Dav1dde
Copy link
Copy Markdown
Member

@Dav1dde Dav1dde commented May 12, 2026

This is no longer exposed in the product. This is also the first step of removing the reservoir sampling code from Relay.

@Dav1dde Dav1dde requested a review from a team as a code owner May 12, 2026 09:14
@Dav1dde Dav1dde requested review from a team and shellmayr May 12, 2026 09:15
@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Comment on lines +53 to +57
type: 'factor' | 'sampleRate' | 'minimumSampleRate';
value: number;
limit?: number;
};
type: 'trace' | 'transaction';
type: 'trace' | 'transaction' | 'project';
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by fix, to add new types which we added to Relay but never to the frontend here

Comment thread static/gsAdmin/views/dynamicSamplingPanel.spec.tsx
Comment thread src/sentry/dynamic_sampling/rules/utils.py
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

📊 Type Coverage Diff

✅ No new type safety issues introduced. Coverage: 93.49%

Comment thread static/gsAdmin/views/dynamicSamplingPanel.tsx
Comment thread static/gsAdmin/views/dynamicSamplingPanel.spec.tsx
Comment thread static/gsAdmin/views/dynamicSamplingPanel.tsx
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d47adcb. Configure here.

Comment thread src/sentry/dynamic_sampling/rules/utils.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants