🐛 fix[gitlab]: sync assignees by external id#115356
Draft
iamrajjoshi wants to merge 1 commit into
Draft
Conversation
iamrajjoshi
commented
May 12, 2026
| If assign=True, we're assigning the issue. Otherwise, deassign. | ||
| """ | ||
| client = self.get_client() | ||
| lifecycle = kwargs.get("lifecycle") |
Collaborator
Author
There was a problem hiding this comment.
temporary shim so i can try to get some more context
dd53ec7 to
d3b924f
Compare
iamrajjoshi
commented
May 12, 2026
| logger = logging.getLogger("sentry.integrations.gitlab.issue_sync") | ||
|
|
||
|
|
||
| def _add_lifecycle_extras(lifecycle: Any, extras: Mapping[str, Any]) -> None: |
Collaborator
Author
There was a problem hiding this comment.
temp should be thrown away
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
i am not fully certain this is the root cause of the GitLab assignment sync failures yet and haven't been able to repro
The leading hypothesis is that inbound assignment is sometimes trying to match by GitLab username when the stable mapped GitLab user ID is available, and outbound assignment can currently fail to resolve a GitLab assignee while still looking successful in lifecycle metrics.
This change updates GitLab assignee sync to prefer mapped GitLab user IDs, fall back to exact username matching, and halt outbound assignment sync when no valid GitLab assignee can be resolved.
Incase my hypothesis is wrong , i also added lifecycle extras around inbound and outbound assignment matching to debug more.