Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import {trackAnalytics} from 'sentry/utils/analytics';
import {useLocalStorageState} from 'sentry/utils/useLocalStorageState';
import {useOrganization} from 'sentry/utils/useOrganization';
import {SectionKey} from 'sentry/views/issueDetails/streamline/context';
import {InterimSection} from 'sentry/views/issueDetails/streamline/interimSection';
import {FoldSection} from 'sentry/views/issueDetails/streamline/foldSection';

interface BreadcrumbsDataSectionProps {
event: Event;
Expand Down Expand Up @@ -164,11 +164,9 @@ export function BreadcrumbsDataSection({
const numHiddenCrumbs = enhancedCrumbs.length - summaryCrumbs.length;

return (
<InterimSection
key="breadcrumbs"
type={SectionKey.BREADCRUMBS}
<FoldSection
sectionKey={SectionKey.BREADCRUMBS}
title={t('Breadcrumbs')}
data-test-id="breadcrumbs-data-section"
actions={actions}
initialCollapse={initialCollapse}
>
Expand Down Expand Up @@ -201,7 +199,7 @@ export function BreadcrumbsDataSection({
</ViewAllContainer>
)}
</ErrorBoundary>
</InterimSection>
</FoldSection>
);
}

Expand Down
21 changes: 5 additions & 16 deletions static/app/components/events/contexts/contextDataSection.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
import {ExternalLink} from '@sentry/scraps/link';

import {ErrorBoundary} from 'sentry/components/errorBoundary';
import {getOrderedContextItems} from 'sentry/components/events/contexts';
import {ContextCard} from 'sentry/components/events/contexts/contextCard';
import {CONTEXT_DOCS_LINK} from 'sentry/components/events/contexts/utils';
import {KeyValueData} from 'sentry/components/keyValueData';
import {t, tct} from 'sentry/locale';
import {t} from 'sentry/locale';
import type {Event} from 'sentry/types/event';
import type {Project} from 'sentry/types/project';
import {SectionKey} from 'sentry/views/issueDetails/streamline/context';
import {InterimSection} from 'sentry/views/issueDetails/streamline/interimSection';
import {FoldSection} from 'sentry/views/issueDetails/streamline/foldSection';

interface ContextDataSectionProps {
event: Event;
Expand Down Expand Up @@ -40,22 +37,14 @@ export function ContextDataSection({
}

return (
<InterimSection
key="context"
type={SectionKey.CONTEXTS}
<FoldSection
sectionKey={SectionKey.CONTEXTS}
title={t('Contexts')}
help={tct(
'The structured context items attached to this event. [link:Learn more]',
{
link: <ExternalLink openInNewTab href={CONTEXT_DOCS_LINK} />,
}
)}
isHelpHoverable
disableCollapsePersistence={disableCollapsePersistence}
>
<ErrorBoundary mini message={t('There was a problem loading event context.')}>
<KeyValueData.Container>{cards}</KeyValueData.Container>
</ErrorBoundary>
</InterimSection>
</FoldSection>
);
}
6 changes: 3 additions & 3 deletions static/app/components/events/device.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {t} from 'sentry/locale';
import type {Event} from 'sentry/types/event';
import {isEmptyObject} from 'sentry/utils/object/isEmptyObject';
import {SectionKey} from 'sentry/views/issueDetails/streamline/context';
import {InterimSection} from 'sentry/views/issueDetails/streamline/interimSection';
import {FoldSection} from 'sentry/views/issueDetails/streamline/foldSection';

import {KeyValueList} from './interfaces/keyValueList';

Expand All @@ -24,7 +24,7 @@ export function EventDevice({event}: Props) {
}

return (
<InterimSection type={SectionKey.DEVICE} title={t('Device')}>
<FoldSection sectionKey={SectionKey.DEVICE} title={t('Device')}>
<KeyValueList
shouldSort={false}
data={[
Expand All @@ -46,6 +46,6 @@ export function EventDevice({event}: Props) {
...extras,
]}
/>
</InterimSection>
</FoldSection>
);
}
12 changes: 6 additions & 6 deletions static/app/components/events/eventAttachments.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {useLocation} from 'sentry/utils/useLocation';
import {useOrganization} from 'sentry/utils/useOrganization';
import {InlineEventAttachment} from 'sentry/views/issueDetails/groupEventAttachments/inlineEventAttachment';
import {SectionKey} from 'sentry/views/issueDetails/streamline/context';
import {InterimSection} from 'sentry/views/issueDetails/streamline/interimSection';
import {FoldSection} from 'sentry/views/issueDetails/streamline/foldSection';
import {Tab, TabPaths} from 'sentry/views/issueDetails/types';
import {useGroupDetailsRoute} from 'sentry/views/issueDetails/useGroupDetailsRoute';

Expand Down Expand Up @@ -86,12 +86,12 @@ function EventAttachmentsContent({

if (isError) {
return (
<InterimSection type={SectionKey.ATTACHMENTS} title={t('Attachments')}>
<FoldSection sectionKey={SectionKey.ATTACHMENTS} title={t('Attachments')}>
<LoadingError
onRetry={refetch}
message={t('An error occurred while fetching attachments')}
/>
</InterimSection>
</FoldSection>
);
}

Expand All @@ -113,8 +113,8 @@ function EventAttachmentsContent({
};

return (
<InterimSection
type={SectionKey.ATTACHMENTS}
<FoldSection
sectionKey={SectionKey.ATTACHMENTS}
title={title}
actions={project && group ? <ViewAllGroupAttachmentsButton /> : null}
disableCollapsePersistence={disableCollapsePersistence}
Expand Down Expand Up @@ -179,7 +179,7 @@ function EventAttachmentsContent({
))}
</StyledPanelTable>
)}
</InterimSection>
</FoldSection>
);
}

Expand Down
2 changes: 1 addition & 1 deletion static/app/components/events/eventDataSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {DataSection} from 'sentry/components/events/styles';
import {QuestionTooltip} from 'sentry/components/questionTooltip';
import {IconLink} from 'sentry/icons';

export interface EventDataSectionProps {
interface EventDataSectionProps {
children: React.ReactNode;
/**
* The title of the section
Expand Down
9 changes: 4 additions & 5 deletions static/app/components/events/eventEvidence.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
getIssueCategoryAndTypeFromOccurrenceType,
} from 'sentry/utils/issueTypeConfig';
import {SectionKey} from 'sentry/views/issueDetails/streamline/context';
import {InterimSection} from 'sentry/views/issueDetails/streamline/interimSection';
import {FoldSection} from 'sentry/views/issueDetails/streamline/foldSection';

type EvidenceProps = {
event: Event;
Expand Down Expand Up @@ -46,10 +46,9 @@ export function EventEvidence({
}

return (
<InterimSection
type={SectionKey.EVIDENCE}
<FoldSection
sectionKey={SectionKey.EVIDENCE}
title={config.title}
help={config.helpText}
disableCollapsePersistence={disableCollapsePersistence}
>
<KeyValueList
Expand All @@ -60,6 +59,6 @@ export function EventEvidence({
}))}
shouldSort={false}
/>
</InterimSection>
</FoldSection>
);
}
8 changes: 4 additions & 4 deletions static/app/components/events/eventExtraData/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import type {Event} from 'sentry/types/event';
import {defined} from 'sentry/utils';
import {isEmptyObject} from 'sentry/utils/object/isEmptyObject';
import {SectionKey} from 'sentry/views/issueDetails/streamline/context';
import {InterimSection} from 'sentry/views/issueDetails/streamline/interimSection';
import {FoldSection} from 'sentry/views/issueDetails/streamline/foldSection';

import {getEventExtraDataKnownDataDetails} from './getEventExtraDataKnownDataDetails';
import type {EventExtraDataType, EventExtraData as TEventExtraData} from './types';
Expand Down Expand Up @@ -42,8 +42,8 @@ export function EventExtraData({event}: Props) {
}

return (
<InterimSection
type={SectionKey.EXTRA}
<FoldSection
sectionKey={SectionKey.EXTRA}
title={t('Additional Data')}
actions={
<SegmentedControl
Expand All @@ -58,6 +58,6 @@ export function EventExtraData({event}: Props) {
}
>
{contextBlock}
</InterimSection>
</FoldSection>
);
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {getReplayDiffOffsetsFromEvent} from 'sentry/utils/replays/getDiffTimesta
import {useLoadReplayReader} from 'sentry/utils/replays/hooks/useLoadReplayReader';
import {useOrganization} from 'sentry/utils/useOrganization';
import {SectionKey} from 'sentry/views/issueDetails/streamline/context';
import {InterimSection} from 'sentry/views/issueDetails/streamline/interimSection';
import {FoldSection} from 'sentry/views/issueDetails/streamline/foldSection';

interface Props {
event: Event;
Expand All @@ -37,41 +37,41 @@ export default function ReplayDiffContent({event, group, orgSlug, replaySlug}: P
});

const sectionProps = {
type: SectionKey.HYDRATION_DIFF,
sectionKey: SectionKey.HYDRATION_DIFF,
title: t('Hydration Error Diff'),
};

return (
<ReplayLoadingState
readerResult={readerResult}
renderArchived={() => (
<InterimSection {...sectionProps}>
<FoldSection {...sectionProps}>
<ArchivedReplayAlert
message={t('The replay for this event has been deleted.')}
/>
</InterimSection>
</FoldSection>
)}
renderLoading={() => (
<InterimSection {...sectionProps}>
<FoldSection {...sectionProps}>
<StyledNegativeSpaceContainer data-test-id="replay-diff-loading-placeholder">
<LoadingIndicator />
</StyledNegativeSpaceContainer>
</InterimSection>
</FoldSection>
)}
renderError={() => (
<InterimSection {...sectionProps}>
<FoldSection {...sectionProps}>
<MissingReplayAlert orgSlug={orgSlug} />
</InterimSection>
</FoldSection>
)}
renderThrottled={() => (
<InterimSection {...sectionProps}>
<FoldSection {...sectionProps}>
<ReplayRequestsThrottledAlert />
</InterimSection>
</FoldSection>
)}
renderMissing={() => (
<InterimSection {...sectionProps}>
<FoldSection {...sectionProps}>
<MissingReplayAlert orgSlug={orgSlug} />
</InterimSection>
</FoldSection>
)}
>
{({replay}) => {
Expand All @@ -80,7 +80,7 @@ export default function ReplayDiffContent({event, group, orgSlug, replaySlug}: P
event
);
return (
<InterimSection
<FoldSection
{...sectionProps}
actions={
<OpenReplayComparisonButton
Expand Down Expand Up @@ -108,7 +108,7 @@ export default function ReplayDiffContent({event, group, orgSlug, replaySlug}: P
</DiffCompareContextProvider>
</ReplayGroupContextProvider>
</ErrorBoundary>
</InterimSection>
</FoldSection>
);
}}
</ReplayLoadingState>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import type {Group} from 'sentry/types/group';
import {useOrganization} from 'sentry/utils/useOrganization';
import {SectionKey} from 'sentry/views/issueDetails/streamline/context';
import {SectionDivider} from 'sentry/views/issueDetails/streamline/foldSection';
import {InterimSection} from 'sentry/views/issueDetails/streamline/interimSection';
import {FoldSection} from 'sentry/views/issueDetails/streamline/foldSection';

interface Props {
event: Event;
Expand All @@ -36,14 +36,14 @@ export function ReplayDiffSection({event, group, replayId}: Props) {
replaySlug={replayId}
LazyComponent={ReplayDiffContent}
loadingFallback={
<InterimSection
type={SectionKey.HYDRATION_DIFF}
<FoldSection
sectionKey={SectionKey.HYDRATION_DIFF}
title={t('Hydration Error Diff')}
>
<StyledNegativeSpaceContainer data-test-id="replay-diff-loading-placeholder">
<LoadingIndicator />
</StyledNegativeSpaceContainer>
</InterimSection>
</FoldSection>
}
/>
</ReactLazyLoad>
Expand Down
6 changes: 3 additions & 3 deletions static/app/components/events/eventInsightDiff.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
useSizeAnalysisComparison,
} from 'sentry/utils/preprod/useSizeAnalysisComparison';
import {SectionKey} from 'sentry/views/issueDetails/streamline/context';
import {InterimSection} from 'sentry/views/issueDetails/streamline/interimSection';
import {FoldSection} from 'sentry/views/issueDetails/streamline/foldSection';
import {InsightComparisonSection} from 'sentry/views/preprod/buildComparison/main/insightComparisonSection';

type SectionProps = MetricIds & {project: Project};
Expand Down Expand Up @@ -50,15 +50,15 @@ function EventInsightDiffContent({baseMetricId, headMetricId, project}: SectionP

function EventInsightDiffSection({baseMetricId, headMetricId, project}: SectionProps) {
return (
<InterimSection title={t('Insight Diff')} type={SectionKey.INSIGHT_DIFF}>
<FoldSection title={t('Insight Diff')} sectionKey={SectionKey.INSIGHT_DIFF}>
<ErrorBoundary mini>
<EventInsightDiffContent
project={project}
headMetricId={headMetricId}
baseMetricId={baseMetricId}
/>
</ErrorBoundary>
</InterimSection>
</FoldSection>
);
}

Expand Down
8 changes: 4 additions & 4 deletions static/app/components/events/eventProcessingErrors.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {t, tct} from 'sentry/locale';
import type {Event} from 'sentry/types/event';
import type {Project} from 'sentry/types/project';
import {SectionKey} from 'sentry/views/issueDetails/streamline/context';
import {InterimSection} from 'sentry/views/issueDetails/streamline/interimSection';
import {FoldSection} from 'sentry/views/issueDetails/streamline/foldSection';

type Props = {
event: Event;
Expand Down Expand Up @@ -124,15 +124,15 @@ export function EventProcessingErrors({event, project, isShare}: Props) {
}

return (
<InterimSection
<FoldSection
sectionKey={SectionKey.PROCESSING_ERROR}
title={t('Event Processing Errors')}
type={SectionKey.PROCESSING_ERROR}
>
<KeyValueData.Container>
{errors.map((error, idx) => {
return <EventErrorDescription key={idx} error={error} />;
})}
</KeyValueData.Container>
</InterimSection>
</FoldSection>
);
}
Loading
Loading