fix(integrations): allow blank overview on sentry app form#114946
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.44% |
The overview field on the sentry app integration form is documented as optional (required=False, allow_null=True), but DRF's CharField defaults to allow_blank=False. The form submits an empty string for an empty textarea, which the serializer rejected with "This field may not be blank." Sending null instead is not viable: SentryAppUpdater._update_overview treats None as "no change" and skips the write, so users could not clear an existing description. Add allow_blank=True so an empty string is accepted and persisted, which matches the behavior of the neighboring webhookUrl and redirectUrl fields.
priscilawebdev
force-pushed
the
priscila/fix/sentry-app-overview-blank
branch
from
57f4abe to
46e0676
Compare
priscilawebdev
changed the title
github-actions
Bot
added
the
Scope: Backend
priscilawebdev
removed
the
Scope: Frontend
priscilawebdev
requested review from
a team and
shellmayr
and removed request for
shellmayr
TkDodo
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue below that occurs when clearing the field and attempting to save. Since the field is optional, saving without a value should be allowed.
Screen.Recording.2026-05-06.at.12.41.38.mov
Note: this form is not yet migrated to the tanstack form