Skip to content

feat(forms): Add sentry-app-schema-form-migration flag#114945

Merged
priscilawebdev merged 2 commits intomasterfrom
priscila/feat/sentry-app-schema-form-migration-flag
May 6, 2026
Merged

feat(forms): Add sentry-app-schema-form-migration flag#114945
priscilawebdev merged 2 commits intomasterfrom
priscila/feat/sentry-app-schema-form-migration-flag

Conversation

@priscilawebdev
Copy link
Copy Markdown
Member

@priscilawebdev priscilawebdev commented May 6, 2026

Register the organizations:sentry-app-schema-form-migration feature flag.

Refs #112911

Gate the migration of Sentry App schema-backed forms from the legacy
FormModel/JsonForm path to the new BackendJsonSubmitForm runtime.

Frontend consumers (SentryAppExternalIssueForm, SentryAppRuleModal) will
branch on this flag so the rewrite can be rolled out per-org via Flagpole
and rolled back instantly if a third-party Sentry App schema hits an
edge case in the new path.

Refs DE-1055
Co-Authored-By: Claude <noreply@anthropic.com>
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 6, 2026

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 6, 2026
Reword the inline comment so it describes what the flag does
(render the form using the backend JSON form adapter) rather than
referring to a one-off migration path.
@priscilawebdev priscilawebdev requested review from a team and shellmayr May 6, 2026 09:47
@priscilawebdev priscilawebdev marked this pull request as ready for review May 6, 2026 10:49
@priscilawebdev priscilawebdev merged commit c12d3dd into master May 6, 2026
81 checks passed
@priscilawebdev priscilawebdev deleted the priscila/feat/sentry-app-schema-form-migration-flag branch May 6, 2026 10:50
priscilawebdev added a commit that referenced this pull request May 6, 2026
Restore the pre-migration class component as sentryAppExternalForm.legacy.tsx
(exported as LegacySentryAppExternalForm) and have the two consumers —
SentryAppExternalIssueForm and SentryAppRuleModal — pick between the
legacy and new form based on the organizations:sentry-app-schema-form-migration
flag.

Add Sentry.captureException to the new form's two failure paths so we can
observe issues during rollout:
  - Save: onError of the create-external-issue mutation
  - Edit: dependent-field initialization (Promise.all of fetchFieldChoices
    when the form opens)

The flag is registered in #114945 and rolled out via
getsentry/sentry-options-automator#7678.

Refs DE-1055
Refs #114945
Refs #112911
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants