feat(forms): Add sentry-app-schema-form-migration flag#114945
Merged
priscilawebdev merged 2 commits intomasterfrom May 6, 2026
Merged
feat(forms): Add sentry-app-schema-form-migration flag#114945priscilawebdev merged 2 commits intomasterfrom
priscilawebdev merged 2 commits intomasterfrom
Conversation
Gate the migration of Sentry App schema-backed forms from the legacy FormModel/JsonForm path to the new BackendJsonSubmitForm runtime. Frontend consumers (SentryAppExternalIssueForm, SentryAppRuleModal) will branch on this flag so the rewrite can be rolled out per-org via Flagpole and rolled back instantly if a third-party Sentry App schema hits an edge case in the new path. Refs DE-1055 Co-Authored-By: Claude <noreply@anthropic.com>
Reword the inline comment so it describes what the flag does (render the form using the backend JSON form adapter) rather than referring to a one-off migration path.
shellmayr
approved these changes
May 6, 2026
priscilawebdev
added a commit
that referenced
this pull request
May 6, 2026
Restore the pre-migration class component as sentryAppExternalForm.legacy.tsx (exported as LegacySentryAppExternalForm) and have the two consumers — SentryAppExternalIssueForm and SentryAppRuleModal — pick between the legacy and new form based on the organizations:sentry-app-schema-form-migration flag. Add Sentry.captureException to the new form's two failure paths so we can observe issues during rollout: - Save: onError of the create-external-issue mutation - Edit: dependent-field initialization (Promise.all of fetchFieldChoices when the form opens) The flag is registered in #114945 and rolled out via getsentry/sentry-options-automator#7678. Refs DE-1055 Refs #114945 Refs #112911 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the
organizations:sentry-app-schema-form-migrationfeature flag.Refs #112911