fix(trace-details): Show replacement attributes when no deprecated source exists#114943
Merged
obostjancic merged 4 commits intomasterfrom May 6, 2026
Merged
Conversation
…urce exists When use_sentry_conventions is off, span details unconditionally hid all replacement attributes (e.g. gen_ai.usage.input_tokens, gen_ai.input.messages). This worked during migration when both old and new names coexisted, but once SDKs send only the new names, the data silently disappeared from the span detail view. Now only filter out replacement attributes when their deprecated source is actually present in the response. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
shellmayr
reviewed
May 6, 2026
| deprecated_names = get_deprecated_source_internal_names( | ||
| external_name, trace_item_type | ||
| ) | ||
| if any(name in all_internal_names for name in deprecated_names): |
Member
There was a problem hiding this comment.
Since this is probably going to be an ever-growing list, we could opt for set intersection > 0 here instead, otherwise this for loop will keep taking longer and longer
Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
constantinius
approved these changes
May 6, 2026
obostjancic
deleted the
obostjancic/fix/span-details-missing-replacement-attributes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gen_ai.usage.input_tokens,gen_ai.input.messages,gen_ai.output.messages) when theperformance-sentry-conventions-fieldsflag was off (currently at 0% rollout)