ref(onboarding): migrate storeCrashReports config#114942
Draft
priscilawebdev wants to merge 1 commit intomasterfrom
Draft
ref(onboarding): migrate storeCrashReports config#114942priscilawebdev wants to merge 1 commit intomasterfrom
priscilawebdev wants to merge 1 commit intomasterfrom
Conversation
Migrate StoreCrashReportsConfig from the legacy JsonForm/Form system to AutoSaveForm. Behavior is preserved: the project-level setting still auto-saves on change, supports the inherit-from-organization option, and respects the event-attachments feature gate and project:write access.
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.40% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
StoreCrashReportsConfigfrom the legacyForm+JsonFormsystem toAutoSaveForm(built onuseScrapsForm).Behavior is preserved:
null) and the rest of the per-issue limitsevent-attachmentsfeature gate andproject:writeaccessformatStoreCrashReportsandgetStoreCrashReportsValuesfor option labelsThe legacy form pulled the field config out of
projectSecurityAndPrivacyGroups; the new form inlines the field declaratively, mirroring the org-level migration instatic/app/views/settings/organizationSecurityAndPrivacy/index.tsx.allowUndois intentionally dropped per the form migration guide.The component renders inside getting-started docs (not Settings), so no
FormSearchwrapper is needed — the project security & privacy settings page still owns the search registry entry for this field.