ref(types): narrow type in Promise.catch from any to unknown#114849
Merged
Conversation
Collaborator
Author
|
bugbot run |
Contributor
📊 Type Coverage Diff
🔍 6 new type safety issues introducedType assertions (
This is informational only and does not block the PR. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9e84ef3. Configure here.
The TFul generic parameter was missing the = T default that the standard TypeScript Promise interface provides. Without it, calling .then(null, rejectionHandler) infers TFul as unknown instead of T, collapsing the result to Promise<unknown>. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds a global type declaration that overrides
Promise.catchand.thenrejection callbacks to receiveunknowninstead ofany. This forces explicit type narrowing at every catch site, preventing silent property access on untyped error objects.Type Declaration
A new
static/app/types/promise.d.tsre-declares thePromiseinterface so thatonrejectedreceivesunknown. This is the same approach TypeScript uses forcatch(e)in try/catch blocks sinceuseUnknownInCatchVariables, but applied to Promise chains which TypeScript doesn't cover natively.Call Site Fixes
Each
.catch/.then(_, onrejected)handler is updated to narrow the error before accessing properties — typically viainstanceof RequestError, explicit(err: Error)annotations, or(err: any)where the handler's shape is too dynamic to narrow cleanly right now.