Ref(Capacitor): Update getting started from new projects#113913
Ref(Capacitor): Update getting started from new projects#113913priscilawebdev merged 10 commits intogetsentry:masterfrom
Conversation
…etsentry#113806) The queue gate in `commit_context.py` reads `sentry:github_pr_bot` / `sentry:gitlab_pr_bot` with `default=False`, but the task body in `tasks.py` re-read the same option with `default=True`. getsentry#103525 flipped the default to off everywhere but missed this call site, so if the option was cleared between enqueue and execution the task would run against the old default-on behavior. Since the queue gate is the only enqueue path (`commit_context.py:458-461`, called from `queue_pr_comment_task_if_needed`), the `default=True` branch is effectively dead in the common case, but the asymmetry is a latent bug if the option is deleted between enqueue and task pickup. Aligning the defaults to `False` matches the intent of getsentry#103525. Co-authored-by: Claude <noreply@anthropic.com>
…emove session replay
github-actions
Bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
|
GH got confused with the changes so I had to remove line by line |
|
approving to unblock but we shouldn't need approval from the value discovery team for these changes, feel free to add yourself to the codeowner for the relevant wizard files |
|
Adding a note that I can't merge PRs here @bruno-garcia does it mean @antonis and @alwx should also be code owners for the React Native wizard files? |
|
I'd add team-mobile or something. I'm just saying there's no need to have the team working on onboarding sign off on all new project wizard changes. Have the domain experts (SDK engineers) be code owners in addition at least |
priscilawebdev
added
the
Trigger: getsentry tests
5 participants
This PR updates the getting started of capacitor with the following changes:
Next Steps
Close getsentry/sentry-capacitor#1203