Skip to content

fix(ui): defer scroll restoration#109885

Merged
natemoo-re merged 12 commits intomasterfrom
ui/nm-fix-scroll
Mar 4, 2026
Merged

fix(ui): defer scroll restoration#109885
natemoo-re merged 12 commits intomasterfrom
ui/nm-fix-scroll

Conversation

@natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Mar 4, 2026

Follow-up to #109663. @sentry caught a legit race condition, so here's the fix.

Confirming in preview deployment

@natemoo-re natemoo-re requested a review from a team as a code owner March 4, 2026 17:57
@natemoo-re natemoo-re requested a review from scttcper March 4, 2026 17:57
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 4, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@natemoo-re natemoo-re disabled auto-merge March 4, 2026 18:21
natemoo-re and others added 2 commits March 4, 2026 14:17
The test expected jest.runAllTimers() to flush a requestAnimationFrame
callback, but never called jest.useFakeTimers() so the call was a no-op.
@natemoo-re natemoo-re merged commit 2cb9f15 into master Mar 4, 2026
59 checks passed
@natemoo-re natemoo-re deleted the ui/nm-fix-scroll branch March 4, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants