feat(dashboards): reuse explore confidence footers in dashboard widgets#109870
Draft
nsdeschenes wants to merge 8 commits intomasterfrom
Draft
feat(dashboards): reuse explore confidence footers in dashboard widgets#109870nsdeschenes wants to merge 8 commits intomasterfrom
nsdeschenes wants to merge 8 commits intomasterfrom
Conversation
Made-with: Cursor
Contributor
Author
|
@sentry review |
Contributor
Author
|
@cursor review |
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Convert dashboard chart series into Explore TimeSeries before deriving confidence and sampling metadata, and align widget query/raw-count typing with optional sampling fields returned by shared helpers. Refs LOGS-586 Made-with: Cursor
Gate useWidgetRawCounts by display type so table/big number/details and other non-timeseries widgets do not issue normal and high-accuracy raw count queries. Add a regression test to ensure these requests stay disabled. Made-with: Cursor
Route LOGS widgets through a dedicated query component so confidence footer metadata comes from raw timeseries responses instead of generic query fallbacks. Made-with: Cursor
Only derive sampling state from fallback series when sampling fields are present. This prevents logs confidence footers from showing zero-count estimates. Made-with: Cursor
Contributor
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataScanned,sampleCount,isSampled) through widget query layers and add focused tests for spans + trace metrics confidence behavior.Refs LOGS-586
Made with Cursor