fix(rails): Track request queue time in Rails middleware#2877
Merged
fix(rails): Track request queue time in Rails middleware#2877
Conversation
dingsdax
requested review from
sl0thentr0py and
solnic
and removed request for
sl0thentr0py
The Rails CaptureExceptions middleware subclass overrode start_transaction without calling super, so the http.server.request.time_in_queue attachment added in #2838 was silently skipped for all Rails apps. Extract queue time attachment into a private attach_queue_time method on the Rack base class so the Rails subclass can invoke it explicitly while keeping its own options hash (preserving the correct SPAN_ORIGIN constant "auto.http.rails" via lexical scoping). Fixes #2873 Co-Authored-By: Claude <noreply@anthropic.com>
dingsdax
force-pushed
the
fix/rails-queue-time-2873
branch
from
a57883c to
3061645
Compare
sl0thentr0py
approved these changes
Mar 2, 2026
This was referenced Mar 2, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rails CaptureExceptions middleware subclass overrode start_transaction without calling super, so the
http.server.request.time_in_queueattachment added in #2838 was silently skipped for all Rails apps.Extract queue time attachment into a private
attach_queue_timemethod on the Rack base class so the Rails subclass can invoke it explicitly while keeping its own options hash (preserving the correct SPAN_ORIGIN constant "auto.http.rails" via lexical scoping).Fixes #2873