Skip to content

chore(ci): Upgrade performance test apps to React Native 0.85.1 #6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 6 commits into from
May 6, 2026
Merged

chore(ci): Upgrade performance test apps to React Native 0.85.1 #6088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c584857
chore(ci): Upgrade performance test apps to React Native 0.85.1
antonis May 5, 2026
19e42fb
fix(ci): Set REACT_NATIVE_NODE_MODULES_DIR for perf test iOS builds
antonis May 5, 2026
fbd7702
chore(ios): Bump iOS binary size limit from 1470 to 1550 KiB
antonis May 5, 2026
a7c5dd4
Merge branch 'main' into antonis/upgrade-perf-test-apps-rn-0.85.1
antonis May 6, 2026
698016d
chore(ios): Relax iOS startup time diffMin from -20 to -3000
antonis May 6, 2026
690bc89
Merge branch 'main' into antonis/upgrade-perf-test-apps-rn-0.85.1
antonis May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/e2e-v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ jobs:
if [[ ${{ matrix.rn-architecture }} == 'new' ]]; then
export RCT_NEW_ARCH_ENABLED=1
fi
export REACT_NATIVE_NODE_MODULES_DIR="$PWD/../node_modules/react-native"
bundle install
bundle exec pod install
cd ../..
Expand Down Expand Up @@ -188,6 +189,7 @@ jobs:
if [[ ${{ matrix.rn-architecture }} == 'new' ]]; then
export RCT_NEW_ARCH_ENABLED=1
fi
export REACT_NATIVE_NODE_MODULES_DIR="$PWD/../node_modules/react-native"
bundle install
bundle exec pod install
cd ../..
Expand Down
1 change: 1 addition & 0 deletions performance-tests/TestAppPlain/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ gem 'bigdecimal'
gem 'logger'
gem 'benchmark'
gem 'mutex_m'
gem 'nkf'
6 changes: 3 additions & 3 deletions performance-tests/TestAppPlain/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
buildscript {
ext {
buildToolsVersion = "35.0.0"
buildToolsVersion = "36.0.0"
minSdkVersion = 24
compileSdkVersion = 35
targetSdkVersion = 35
compileSdkVersion = 36
targetSdkVersion = 36
ndkVersion = "27.1.12297006"
kotlinVersion = "2.1.20"
}
Expand Down
5 changes: 5 additions & 0 deletions performance-tests/TestAppPlain/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,8 @@ newArchEnabled=false
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

# Use this property to enable edge-to-edge display support.
# This allows your app to draw behind system bars for an immersive UI.
# Note: Only works with ReactActivity and should not be used with custom Activity.
edgeToEdgeEnabled=false
2 changes: 1 addition & 1 deletion performance-tests/TestAppPlain/android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
20 changes: 10 additions & 10 deletions performance-tests/TestAppPlain/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,24 @@
"start": "react-native start"
},
"dependencies": {
"react": "19.1.0",
"react-native": "0.80.2"
"react": "19.2.3",
"react-native": "0.85.1"
},
"devDependencies": {
"@babel/core": "^7.25.2",
"@babel/preset-env": "^7.25.3",
"@babel/runtime": "^7.25.0",
"@react-native-community/cli": "19.1.2",
"@react-native-community/cli-platform-android": "19.1.1",
"@react-native-community/cli-platform-ios": "19.1.1",
"@react-native/babel-preset": "0.80.2",
"@react-native/metro-config": "0.80.2",
"@react-native/typescript-config": "0.80.2",
"@react-native-community/cli": "20.1.0",
"@react-native-community/cli-platform-android": "20.1.0",
"@react-native-community/cli-platform-ios": "20.1.0",
"@react-native/babel-preset": "0.85.1",
"@react-native/metro-config": "0.85.1",
"@react-native/typescript-config": "0.85.1",
"@types/jest": "^29.5.13",
"@types/react": "^19.1.0",
"@types/react": "^19.1.1",
"@types/react-test-renderer": "^19.1.0",
"jest": "^29.6.3",
"react-test-renderer": "19.1.0",
"react-test-renderer": "19.2.3",
"typescript": "5.0.4"
},
"engines": {
Expand Down
1 change: 1 addition & 0 deletions performance-tests/TestAppSentry/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ gem 'bigdecimal'
gem 'logger'
gem 'benchmark'
gem 'mutex_m'
gem 'nkf'
6 changes: 3 additions & 3 deletions performance-tests/TestAppSentry/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
buildscript {
ext {
buildToolsVersion = "35.0.0"
buildToolsVersion = "36.0.0"
minSdkVersion = 24
compileSdkVersion = 35
targetSdkVersion = 35
compileSdkVersion = 36
targetSdkVersion = 36
ndkVersion = "27.1.12297006"
kotlinVersion = "2.1.20"
}
Expand Down
5 changes: 5 additions & 0 deletions performance-tests/TestAppSentry/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,8 @@ newArchEnabled=false
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=true

# Use this property to enable edge-to-edge display support.
# This allows your app to draw behind system bars for an immersive UI.
# Note: Only works with ReactActivity and should not be used with custom Activity.
edgeToEdgeEnabled=false
2 changes: 1 addition & 1 deletion performance-tests/TestAppSentry/android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
22 changes: 11 additions & 11 deletions performance-tests/TestAppSentry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,26 @@
"start": "react-native start"
},
"dependencies": {
"@react-native/new-app-screen": "0.80.2",
"@react-native/new-app-screen": "0.85.1",
"@sentry/react-native": "8.10.0",
"react": "19.1.0",
"react-native": "0.80.2"
"react": "19.2.3",
"react-native": "0.85.1"
Comment thread
antonis marked this conversation as resolved.
},
"devDependencies": {
"@babel/core": "^7.25.2",
"@babel/preset-env": "^7.25.3",
"@babel/runtime": "^7.25.0",
"@react-native-community/cli": "19.1.2",
"@react-native-community/cli-platform-android": "19.1.1",
"@react-native-community/cli-platform-ios": "19.1.1",
"@react-native/babel-preset": "0.80.2",
"@react-native/metro-config": "0.80.2",
"@react-native/typescript-config": "0.80.2",
"@react-native-community/cli": "20.1.0",
"@react-native-community/cli-platform-android": "20.1.0",
"@react-native-community/cli-platform-ios": "20.1.0",
"@react-native/babel-preset": "0.85.1",
"@react-native/metro-config": "0.85.1",
"@react-native/typescript-config": "0.85.1",
"@types/jest": "^29.5.13",
"@types/react": "^19.1.0",
"@types/react": "^19.1.1",
"@types/react-test-renderer": "^19.1.0",
"jest": "^29.6.3",
"react-test-renderer": "19.1.0",
"react-test-renderer": "19.2.3",
"sentry-react-native-samples-utils": "workspace:^",
"typescript": "5.0.4"
},
Expand Down
4 changes: 2 additions & 2 deletions performance-tests/metrics-ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@

startupTimeTest:
runs: 50
diffMin: -20
diffMin: -3000

Check warning on line 9 in performance-tests/metrics-ios.yml

View check run for this annotation

@sentry/warden / warden: code-review

startupTimeTest diffMin loosened to -3000 may mask regressions 

The diffMin threshold for startupTimeTest was relaxed from -20 to -3000, a 150x increase in the allowed negative deviation. This effectively disables the lower-bound regression detection for startup time, since a -3000ms improvement is implausible and any real regression toward that magnitude would no longer be flagged. If the RN 0.85.1 upgrade legitimately changed baseline timings, the new bound should be tightened to a realistic value once the baseline stabilizes, otherwise future startup performance regressions in this performance-critical path will go undetected.

Check warning on line 9 in performance-tests/metrics-ios.yml

View check run for this annotation

@sentry/warden / warden: find-bugs

startupTimeTest diffMin lowered to -3000 effectively disables regression detection on improvements side and masks anomalies 

The `diffMin` threshold for `startupTimeTest` was changed from -20 to -3000. Since `diffMin` defines the lower bound of an acceptable startup-time delta, setting it to -3000 ms means virtually any unexpectedly large negative delta (e.g., caused by a broken/short-circuited startup path that no longer initializes required components) will pass the test. This removes the guardrail that detects suspicious startup-time drops, which can hide real regressions where the app appears faster because it isn't doing its initialization work.
Comment thread
antonis marked this conversation as resolved.
Comment thread
antonis marked this conversation as resolved.
diffMax: 150

binarySizeTest:
diffMin: 600 KiB
diffMax: 1470 KiB
diffMax: 1550 KiB
Loading
Loading