Skip to content

fix(core): Trim DSN whitespace before native initialization #6081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 2 commits into from
May 4, 2026
+45 −19
Merged

fix(core): Trim DSN whitespace before native initialization #6081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d6b485
fix(core): Trim DSN whitespace before native initialization
antonis May 4, 2026
7def674
fix(core): Move DSN whitespace trim before empty check
antonis May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/src/js/wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,11 @@ export const NATIVE: SentryNativeWrapper = {
return false;
}

if (options.dsn && options.dsn !== options.dsn.trim()) {
debug.warn('The DSN contains whitespace which can cause native crashes. Whitespace has been trimmed.');
options.dsn = options.dsn.trim();
}

if (!options.dsn) {
debug.warn(
'Warning: No DSN was provided. The Sentry SDK will be disabled. Native SDK will also not be initalized.',
Expand Down
59 changes: 40 additions & 19 deletions packages/core/test/wrapper.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import type { ReactNativeOptions } from '../src/js/options';
import { base64StringFromByteArray, utf8ToBytes } from '../src/js/vendor';
import { NATIVE } from '../src/js/wrapper';

const VALID_DSN = 'https://key@sentry.io/123';

jest.mock('react-native', () => {
let initPayload: ReactNativeOptions | null = null;

Expand Down Expand Up @@ -109,7 +111,7 @@ describe('Tests Native Wrapper', () => {
describe('startWithOptions', () => {
test('calls native module', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
devServerUrl: undefined,
defaultSidecarUrl: undefined,
Expand All @@ -135,11 +137,30 @@ describe('Tests Native Wrapper', () => {
);
});

test('trims whitespace from dsn and warns', async () => {
debug.warn = jest.fn();

await NATIVE.initNativeSdk({
dsn: ` ${VALID_DSN} `,
enableNative: true,
devServerUrl: undefined,
defaultSidecarUrl: undefined,
mobileReplayOptions: undefined,
});

expect(debug.warn).toHaveBeenCalledWith(
'The DSN contains whitespace which can cause native crashes. Whitespace has been trimmed.',
);
expect(RNSentry.initNativeSdk).toHaveBeenCalled();
const initParameter = (RNSentry.initNativeSdk as jest.MockedFunction<any>).mock.calls[0][0];
expect(initParameter.dsn).toBe(VALID_DSN);
});

test('does not call native module with enableNative: false', async () => {
debug.warn = jest.fn();

await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: false,
enableNativeNagger: true,
devServerUrl: undefined,
Expand All @@ -154,7 +175,7 @@ describe('Tests Native Wrapper', () => {

test('filter beforeSend when initializing Native SDK', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: true,
beforeSend: jest.fn(),
Expand All @@ -172,7 +193,7 @@ describe('Tests Native Wrapper', () => {

test('filter beforeBreadcrumb when initializing Native SDK', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: true,
beforeBreadcrumb: jest.fn(),
Expand All @@ -190,7 +211,7 @@ describe('Tests Native Wrapper', () => {

test('filter beforeSendTransaction when initializing Native SDK', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: true,
beforeSendTransaction: jest.fn(),
Expand All @@ -208,7 +229,7 @@ describe('Tests Native Wrapper', () => {

test('filter beforeSendMetric when initializing Native SDK', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: true,
beforeSendMetric: jest.fn(),
Expand All @@ -226,7 +247,7 @@ describe('Tests Native Wrapper', () => {

test('passes attachAllThreads to native SDK', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: true,
attachAllThreads: true,
Expand All @@ -243,7 +264,7 @@ describe('Tests Native Wrapper', () => {

test('filter integrations when initializing Native SDK', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: true,
integrations: [],
Expand All @@ -264,7 +285,7 @@ describe('Tests Native Wrapper', () => {
debug.warn = jest.fn();

await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: false,
devServerUrl: undefined,
Expand Down Expand Up @@ -311,7 +332,7 @@ describe('Tests Native Wrapper', () => {
devServerUrl: undefined,
defaultSidecarUrl: undefined,
mobileReplayOptions: undefined,
dsn: 'test',
dsn: VALID_DSN,
enableNative: false,
autoInitializeNativeSdk: false,
});
Expand All @@ -333,7 +354,7 @@ describe('Tests Native Wrapper', () => {
const regex1 = /foo/;
const regex2 = new RegExp('bar');
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
ignoreErrors: ['string1', regex1, 'string2', regex2],
devServerUrl: undefined,
Expand All @@ -348,7 +369,7 @@ describe('Tests Native Wrapper', () => {

test('does not set ignoreErrorsStr or ignoreErrorsRegex if ignoreErrors is not provided', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
devServerUrl: undefined,
defaultSidecarUrl: undefined,
Expand All @@ -362,7 +383,7 @@ describe('Tests Native Wrapper', () => {

test('does not set enableLogs when option is undefined', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: true,
devServerUrl: undefined,
Expand All @@ -382,7 +403,7 @@ describe('Tests Native Wrapper', () => {
['with logsOrigin set to JS', 'js' as const, false],
])('handles enableLogs %s', async (_description, logsOrigin, expectedEnableLogs) => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: true,
enableLogs: true,
Expand All @@ -400,7 +421,7 @@ describe('Tests Native Wrapper', () => {

test('passes strictTraceContinuation option to native SDK', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: true,
strictTraceContinuation: true,
Expand All @@ -416,7 +437,7 @@ describe('Tests Native Wrapper', () => {

test('passes screenshot options to native SDK', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: true,
screenshot: {
Expand All @@ -442,7 +463,7 @@ describe('Tests Native Wrapper', () => {

test('passes orgId option to native SDK', async () => {
await NATIVE.initNativeSdk({
dsn: 'test',
dsn: VALID_DSN,
enableNative: true,
autoInitializeNativeSdk: true,
orgId: '12345',
Expand Down Expand Up @@ -520,7 +541,7 @@ describe('Tests Native Wrapper', () => {
test('does not call RNSentry at all if enableNative is false', async () => {
try {
await NATIVE.initNativeSdk({
dsn: 'test-dsn',
dsn: VALID_DSN,
enableNative: false,
devServerUrl: undefined,
defaultSidecarUrl: undefined,
Expand Down Expand Up @@ -825,7 +846,7 @@ describe('Tests Native Wrapper', () => {
});
test('does not call crash if enableNative is false', async () => {
await NATIVE.initNativeSdk({
dsn: 'test-dsn',
dsn: VALID_DSN,
enableNative: false,
devServerUrl: undefined,
defaultSidecarUrl: undefined,
Expand Down
Loading