Skip to content

feat(crons): Add owner field to MonitorConfig #5610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julwhitney13 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(crons): Add owner field to MonitorConfig #5610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/build_aws_lambda_layer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class LayerBuilder:
def __init__(
self,
base_dir: str,
out_zip_filename: "Optional[str]"=None,
out_zip_filename: "Optional[str]" = None,
) -> None:
self.base_dir = base_dir
self.python_site_packages = os.path.join(self.base_dir, PYTHON_SITE_PACKAGES)
Expand Down
1 change: 1 addition & 0 deletions sentry_sdk/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ class SDKInfo(TypedDict):
"max_runtime": int,
"failure_issue_threshold": int,
"recovery_threshold": int,
"owner": str,
},
total=False,
)
Expand Down
16 changes: 16 additions & 0 deletions tests/test_crons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,22 @@ def test_monitor_config(sentry_init, capture_envelopes):
assert "monitor_config" not in check_in


def test_monitor_config_with_owner(sentry_init, capture_envelopes):
sentry_init()
envelopes = capture_envelopes()

monitor_config = {
"schedule": {"type": "crontab", "value": "0 0 * * *"},
"owner": "team:6",
}

capture_checkin(monitor_slug="abc123", monitor_config=monitor_config)
check_in = envelopes[0].items[0].payload.json

assert check_in["monitor_slug"] == "abc123"
assert check_in["monitor_config"]["owner"] == "team:6"


def test_decorator_monitor_config(sentry_init, capture_envelopes):
sentry_init()
envelopes = capture_envelopes()
Expand Down