-
Notifications
You must be signed in to change notification settings - Fork 588
feat(pydantic-ai): Add tool description to execute_tool spans #5596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericapisani
wants to merge
9
commits into
master
Choose a base branch
from
ep/add-tool-description-to-pydantic-ai-spans
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+99
−3
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d246712
feat(pydantic-ai): Add tool description to execute_tool spans
ericapisani b07537a
Merge branch 'master' into ep/add-tool-description-to-pydantic-ai-spans
ericapisani a136913
ref(pydantic-ai): Fix type annotation style in execute_tool_span
ericapisani 352c03d
Merge branch 'ep/add-tool-description-to-pydantic-ai-spans' of github…
ericapisani a0bd0dc
test(pydantic-ai): Fix assertion for missing tool description
ericapisani b80dd97
fix(pydantic-ai): Safely access tool description attribute
ericapisani 46743ae
Address CR comments
ericapisani bf85285
cleanups
ericapisani 7a7f2bc
changes to make warden happy
ericapisani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getattr on TypedDict silently returns None, losing description
High Severity
In pydantic-ai,
ToolDefinitionis aTypedDict, which at runtime is just adict. Usinggetattr(tool_definition, "description", None)on a dict instance always returnsNonebecause dict keys are not attributes — it would need to betool_definition.get("description")ortool_definition["description"]instead. This means the tool description feature is silently broken: the span data will always containNonefor the description, even when a tool has a docstring.