feat(clubhouse): Add global search#422
feat(clubhouse): Add global search#422miketheman wants to merge 1 commit intogetsentry:masterfrom miketheman:miketheman/clubhouse-global-search
Conversation
Add a configuration for the user to opt-in for a Sentry project to search across all Clubhouse projects. When the flag is active, skip adding the configured Clubhouse project ID to the search. Resolves #344 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
|
Example UI looks like this:
Not sure what's going on with the CSS and alignment - that's likely somewhere in sentry core? |
|
Amazing, thanks @miketheman ! |
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
This seems like the kind of thing that should have a test case.
|
@markstory Definitely makes sense to have one - I was having trouble finding any examples in the codebase that do configuration validation/mocking and then subsequently testing the resulting request. |
|
So is the desire to no longer have this? Happy to disengage from contributing to the project if it's no longer desired. |
|
Hi @miketheman - closed the PR as this repo is going into archive mode soon and the PR had some merge conflicts. It needs to be ported over to getsentry/sentry anyway for us to merge. If you are still interested, would you mind porting this over to https://github.com/getsentry/sentry/tree/master/src/sentry_plugins/clubhouse ? Sorry for the trouble! Also ping @markstory |
4 participants
Add a configuration for the user to opt-in for a Sentry project to search across all Clubhouse projects.
When the flag is active, skip adding the configured Clubhouse project ID to the search.
Resolves #344
Signed-off-by: Mike Fiedler miketheman@gmail.com