feat(scopes): introduce typed scopes#2139
Open
Litarnus wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces one
Scopeand introduces a total of 3 scopes:GlobalScope- Cannot store spans but can store user data such as tags, contexts, etcIsolationScope- Can store spans and is used to store request local informationsMergedScope- Transient scope that is the result of merging the global and isolation scope. Is considered a read-only scope and should only be used to apply data to eventsWhy different types of scopes?
With only one type of scopes, the burden of knowing when to merge and which one to use where is passed to the developer all the time. While it would work with any scope and it would apply some informations, it's very easy to forget to merge scopes and only get a fraction of the required informations. With having specific types, the signature can ensure that the correct scopes are being used in the correct context. It's also easier to understand intent.
The scopes also expose different methods, meaning that it's impossible to add data to a merged scope which gets discarded afterwards.
All scopes share a common
ScopeDataobject which acts as a data storage to simplify merging/cloning.ScopeDatais effectively what was theScopebefore but without event specific methods