-
-
Notifications
You must be signed in to change notification settings - Fork 204
feat(native): add remote DWARF unwinding + symbol names for Linux #1747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jpnurmi
wants to merge
14
commits into
master
Choose a base branch
from
jpnurmi/feat/native/libunwind-remote
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a6504fa
feat(native): add remote DWARF unwinding + symbol names for Linux
jpnurmi d1818f5
fix(native): keep crash stack buffer for unwind fallback
jpnurmi d23877a
fix(native): heap allocate remote unwind frames
jpnurmi 6a4bb99
Update VENDORING.md
jpnurmi 0602eda
ref(native): align remote unwinder with unwinder dispatch
jpnurmi 5e16a6e
fix(native): prefer signal backtrace for crashed thread
jpnurmi 26c07d5
Update CHANGELOG.md
jpnurmi dcd8ebc
docs(native): clarify stack frame trust assignment
jpnurmi 311e4c4
fix(native): avoid ptrace unwind of crashed thread
jpnurmi a506274
fix(native): verify ptrace stop before remote unwind
jpnurmi af1e9b8
fix(native): wire arm32 remote libunwind build
jpnurmi 2d1abb8
fix(native): silence remote unwinder dispatcher warnings
jpnurmi 95db646
fix(native): omit bogus registers from remote stacks
jpnurmi 4cf3b68
fix(native): attach registers to remote unwind stacks
jpnurmi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,43 @@ | ||
| #ifndef SENTRY_UNWINDER_H_INCLUDED | ||
| #define SENTRY_UNWINDER_H_INCLUDED | ||
|
|
||
| #include "sentry_boot.h" | ||
|
|
||
| #include <stdint.h> | ||
|
|
||
| typedef struct { | ||
| uintptr_t lo, hi; | ||
| } mem_range_t; | ||
|
|
||
| #if defined(SENTRY_PLATFORM_LINUX) | ||
|
|
||
| # include <stddef.h> | ||
| # include <sys/types.h> | ||
|
|
||
| # define SENTRY_REMOTE_UNWIND_MAX_REGISTER_NAME 16 | ||
| # define SENTRY_REMOTE_UNWIND_MAX_REGISTERS 64 | ||
| # define SENTRY_REMOTE_UNWIND_MAX_SYMBOL 256 | ||
|
|
||
| typedef struct { | ||
| char name[SENTRY_REMOTE_UNWIND_MAX_REGISTER_NAME]; | ||
| uint64_t value; | ||
| } sentry_remote_register_t; | ||
|
|
||
| typedef struct { | ||
| uint64_t ip; | ||
| char symbol[SENTRY_REMOTE_UNWIND_MAX_SYMBOL]; | ||
| uint64_t symbol_offset; | ||
| } sentry_remote_frame_t; | ||
|
|
||
| typedef struct { | ||
| size_t count; | ||
| sentry_remote_register_t values[SENTRY_REMOTE_UNWIND_MAX_REGISTERS]; | ||
| } sentry_remote_registers_t; | ||
|
|
||
| size_t sentry__unwind_stack_from_thread(pid_t tid, | ||
| sentry_remote_frame_t *frames, size_t max_frames, | ||
| sentry_remote_registers_t *registers); | ||
|
|
||
| #endif | ||
|
|
||
| #endif // SENTRY_UNWINDER_H_INCLUDED |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.