feat(replay-clip): add attach_replay_clip option with platform extension point#1709
Draft
tustanivsky wants to merge 2 commits intomasterfrom
Draft
feat(replay-clip): add attach_replay_clip option with platform extension point#1709tustanivsky wants to merge 2 commits intomasterfrom
attach_replay_clip option with platform extension point#1709tustanivsky wants to merge 2 commits intomasterfrom
Conversation
|
tustanivsky
changed the title
attach_replay_clip option with platform extension point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two new options to enable attaching a short retroactive video clip to captured crash event:
sentry_options_set_attach_replay_clip(opts, int val)- toggle (default off)sentry_options_set_replay_clip_duration_ms(opts, uint32_t)- requested window (default 5000 ms)It mirrors the existing screenshot architecture: a public option, an internal
sentry_replay_clip.hinterface, a no-op default impl, and an extension point so downstream SDKs (e.g. sentry-xbox usingXAppCaptureRecordDiagnosticClip) can supply a real implementation.Related items:
#skip-changelog