Open
Conversation
Add enum values for offline and always-on cache modes while keeping the existing cache_keep setter as the public entry point. Ensure envelopes kept with SENTRY_CACHE_KEEP_ALWAYS use non-retry cache filenames so they are not picked up by retry processing. Co-Authored-By: OpenAI Codex <noreply@openai.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
When HTTP retry re-sends an envelope with attachment refs, the callback pruned sibling cache files before the retry layer archived keep-always envelopes. Keep referenced siblings so the cached envelope does not point at missing files. Co-Authored-By: Codex <noreply@openai.com>
Pass the app http_retry setting to the crash daemon so consent-revoked crash envelopes are cached in retry format. Keep daemon retry polling disabled and leave restart-time retries to the app process. Co-Authored-By: Codex <noreply@openai.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Store cache_keep as an int in the crash IPC context like other enum-backed fields. Cast at the app and daemon boundaries so enum size flags cannot change the shared-memory layout. Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f0bee65. Configure here.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn
cache_keepinto an enum (with backwards compatible values; false=0, true=1):SENTRY_CACHE_KEEP_NONE(false): Do not keep envelopes in the persistent cache.SENTRY_CACHE_KEEP_OFFLINE(true): The classic Offline Caching mode. Envelopes that cannot be uploaded immediately are cached. Includes send failures and revoked envelopes.SENTRY_CACHE_KEEP_ALWAYS: Envelopes are cached regardless of the upload result.Relates to #1688 but does not fully solve it, as it needs changes in sentry-desktop-crash-reporter, too.