fix(server-utils): Ensure all orchestrion instrumentation lazy registers#22518
Open
isaacs wants to merge 1 commit into
Open
fix(server-utils): Ensure all orchestrion instrumentation lazy registers#22518isaacs wants to merge 1 commit into
isaacs wants to merge 1 commit into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
isaacs
force-pushed
the
isaacs/lazy-register-orchestrion
branch
2 times, most recently
from
July 23, 2026 15:13
73c683a to
d752238
Compare
Member
Author
|
Going to port this atop #22443 once that lands, since there are some conflicts. UPDATE: this is now done. Single commit can base cleanly on |
isaacs
force-pushed
the
isaacs/lazy-register-orchestrion
branch
from
July 23, 2026 22:41
6d6a126 to
464dc8f
Compare
isaacs
added a commit
that referenced
this pull request
Jul 23, 2026
…on Node (#22518) Co-Authored-By: isaacs <i@izs.me> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
isaacs
force-pushed
the
isaacs/lazy-register-orchestrion
branch
from
July 23, 2026 22:43
464dc8f to
ae93c4e
Compare
isaacs
enabled auto-merge (rebase)
July 23, 2026 22:43
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
added a commit
that referenced
this pull request
Jul 24, 2026
isaacs
added a commit
that referenced
this pull request
Jul 24, 2026
…azy registers on Node (#22518)
isaacs
added a commit
that referenced
this pull request
Jul 24, 2026
…on Node (#22518) Co-Authored-By: isaacs <i@izs.me> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
isaacs
force-pushed
the
isaacs/lazy-register-orchestrion
branch
from
July 24, 2026 14:28
38d60ec to
7edaad4
Compare
isaacs
added a commit
that referenced
this pull request
Jul 24, 2026
isaacs
added a commit
that referenced
this pull request
Jul 24, 2026
…azy registers on Node (#22518)
isaacs
added a commit
that referenced
this pull request
Jul 24, 2026
…on Node (#22518) Co-Authored-By: isaacs <i@izs.me> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
isaacs
added a commit
that referenced
this pull request
Jul 24, 2026
isaacs
added a commit
that referenced
this pull request
Jul 24, 2026
…azy registers on Node (#22518)
isaacs
force-pushed
the
isaacs/lazy-register-orchestrion
branch
from
July 24, 2026 16:38
549f754 to
3f5b4ba
Compare
isaacs
added a commit
that referenced
this pull request
Jul 24, 2026
…n Node (#22518) Co-Authored-By: isaacs <i@izs.me> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
isaacs
force-pushed
the
isaacs/lazy-register-orchestrion
branch
from
July 24, 2026 19:44
62e4483 to
96d3ac4
Compare
isaacs
added a commit
that referenced
this pull request
Jul 24, 2026
…on Node (#22518) Co-Authored-By: isaacs <i@izs.me> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
isaacs
force-pushed
the
isaacs/lazy-register-orchestrion
branch
from
July 24, 2026 19:45
96d3ac4 to
bf10337
Compare
…on Node (#22518) Co-Authored-By: isaacs <i@izs.me> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
isaacs
force-pushed
the
isaacs/lazy-register-orchestrion
branch
from
July 24, 2026 22:37
bf10337 to
0f52d62
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0f52d62. Configure here.
| bindNodeRedisBatchChannel(CHANNELS.NODE_REDIS_BATCH, data => | ||
| data.arguments?.[2] !== undefined ? 'MULTI' : 'PIPELINE', | ||
| ); | ||
| } |
There was a problem hiding this comment.
Redis legacy subscribe deferred incorrectly
Medium Severity
subscribeLegacyRedisCommand used to run immediately because redis v2–v3 does not need bindStore. It now sits inside invokeOrchestrionInstrumentation, which always waits on the tracing-channel binding. On the bundler path that list is already populated at setup, so subscription is deferred past Sentry.init() while OpenTelemetry is still coming up, and early redis v2–v3 commands can emit with no subscriber.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 0f52d62. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports and refactors the intent of #22387, using the mechanisms landed on
developin #22094, rather than the mechanisms in #22386 which are similar in intent, but substantially different in implementation.The difference from #22387 is entirely in the plumbing underneath the helper. The way that "is my module injected?" and "tell me when it gets injected" are answered, both now use the machinery that already landed.
Beyond that, the actual registration, event emitting, double-wrap guard, and integration refactoring, should all look very familiar.