Skip to content

feat(ci): cancel in-progress PR workflows on new commit push #20265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshuarli wants to merge 1 commit into from
Closed

feat(ci): cancel in-progress PR workflows on new commit push #20265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/auto-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ on:
- master

# This workflow triggers a release when merging a branch with the pattern `prepare-release/VERSION` into master.

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
Copy link
Copy Markdown

@cursor cursor bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concurrency cancellation risks cancelling release preparation workflow

Medium Severity

Adding cancel-in-progress: true to auto-release.yml is risky and doesn't serve the PR's stated purpose. This workflow only triggers on pull_request: types: [closed], so there's no "new commit push" scenario that would benefit from concurrency cancellation. However, if someone manually re-runs this workflow while the original is still executing (e.g., thinking it's stuck), the concurrency group (keyed on github.head_ref) would cancel the in-progress release preparation via craft, potentially leaving the release in an inconsistent state.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5491706. Configure here.


permissions:
contents: write
pull-requests: write
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/cleanup-pr-caches.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on:
types:
- closed

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
Copy link
Copy Markdown

@cursor cursor bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary concurrency on closed-only and opened-only workflows

Low Severity

The concurrency cancellation added to cleanup-pr-caches.yml (triggers only on closed) and gitflow-merge-conflict.yml (triggers only on opened) serves no practical purpose. These event types fire at most once per PR lifecycle, so there are no "in-progress" runs to cancel when a new commit is pushed. This adds configuration noise without matching the PR's stated intent of cancelling workflows on new commit pushes.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5491706. Configure here.


jobs:
cleanup:
runs-on: ubuntu-latest
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/enforce-license-compliance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ on:
- v9
- v8

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
enforce-license-compliance:
runs-on: ubuntu-24.04
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/gitflow-merge-conflict.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
branches:
- develop

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
check-merge-conflicts:
name: Detect merge conflicts in gitflow PRs
Expand Down
Loading