Skip to content

chore: Enable all Rules and Cleanup Configuration#19612

Draft
logaretm wants to merge 5 commits intodevelopfrom
awad/oxlint-rules-cleanup
Draft

chore: Enable all Rules and Cleanup Configuration#19612
logaretm wants to merge 5 commits intodevelopfrom
awad/oxlint-rules-cleanup

Conversation

@logaretm
Copy link
Member

@logaretm logaretm commented Mar 3, 2026

This is a follow up PR that cleans up our configuration and reverts the downgrade to warning for some of the rules we use. This brings us to a similar level of coverage with eslint.

Some rules have sensitivity issue, especially when it comes to optional chaining and types so we will still have a lot of warnings. I plan to create a warning cleanup PRs in the upcoming days to bring it down to manageable levels.

@logaretm logaretm self-assigned this Mar 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 25.62 kB -0.01% -2 B 🔽
@sentry/browser - with treeshaking flags 24.13 kB -0.02% -3 B 🔽
@sentry/browser (incl. Tracing) 42.43 kB -0.02% -7 B 🔽
@sentry/browser (incl. Tracing, Profiling) 47.09 kB -0.01% -1 B 🔽
@sentry/browser (incl. Tracing, Replay) 81.23 kB -0.02% -16 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 70.85 kB -0.03% -19 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 85.93 kB -0.02% -15 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 98.19 kB -0.02% -18 B 🔽
@sentry/browser (incl. Feedback) 42.44 kB -0.01% -1 B 🔽
@sentry/browser (incl. sendFeedback) 30.29 kB -0.01% -1 B 🔽
@sentry/browser (incl. FeedbackAsync) 35.35 kB -0.01% -2 B 🔽
@sentry/browser (incl. Metrics) 26.79 kB -0.01% -2 B 🔽
@sentry/browser (incl. Logs) 26.93 kB -0.02% -3 B 🔽
@sentry/browser (incl. Metrics & Logs) 27.61 kB -0.02% -3 B 🔽
@sentry/react 27.38 kB -0.01% -2 B 🔽
@sentry/react (incl. Tracing) 44.77 kB -0.02% -5 B 🔽
@sentry/vue 30.07 kB -0.02% -4 B 🔽
@sentry/vue (incl. Tracing) 44.3 kB -0.01% -4 B 🔽
@sentry/svelte 25.65 kB -0.02% -3 B 🔽
CDN Bundle 28.17 kB -0.02% -5 B 🔽
CDN Bundle (incl. Tracing) 43.25 kB -0.03% -11 B 🔽
CDN Bundle (incl. Logs, Metrics) 29.01 kB -0.02% -3 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) 44.09 kB -0.03% -12 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) 68.08 kB -0.03% -15 B 🔽
CDN Bundle (incl. Tracing, Replay) 80.11 kB -0.03% -24 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 80.98 kB -0.03% -21 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 85.63 kB -0.03% -23 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 86.51 kB -0.03% -23 B 🔽
CDN Bundle - uncompressed 82.35 kB -0.01% -5 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 128.02 kB -0.04% -45 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed 85.18 kB -0.01% -5 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 130.86 kB -0.04% -45 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 208.81 kB -0.02% -37 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 244.88 kB -0.04% -77 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 247.69 kB -0.04% -77 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 257.79 kB -0.03% -77 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 260.6 kB -0.03% -77 B 🔽
@sentry/nextjs (client) 47.18 kB -0.02% -5 B 🔽
@sentry/sveltekit (client) 42.89 kB -0.01% -4 B 🔽
@sentry/node-core 52.25 kB +0.02% +8 B 🔺
@sentry/node 174.73 kB +0.02% +21 B 🔺
@sentry/node - without tracing 97.4 kB +0.02% +12 B 🔺
@sentry/aws-serverless 113.2 kB +0.01% +8 B 🔺

View base workflow run

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,684 - 9,435 +3%
GET With Sentry 1,726 18% 1,718 +0%
GET With Sentry (error only) 6,165 64% 6,077 +1%
POST Baseline 1,218 - 1,187 +3%
POST With Sentry 600 49% 577 +4%
POST With Sentry (error only) 1,083 89% 1,028 +5%
MYSQL Baseline 3,326 - 3,257 +2%
MYSQL With Sentry 508 15% 446 +14%
MYSQL With Sentry (error only) 2,727 82% 2,653 +3%

View base workflow run

Base automatically changed from awad/oxlint to develop March 6, 2026 21:52
@logaretm logaretm force-pushed the awad/oxlint-rules-cleanup branch from 1d6c276 to e9ad91b Compare March 6, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant