Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/sveltekit-2/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"eslint-plugin-svelte": "^2.35.1",
"prettier": "^3.1.1",
"prettier-plugin-svelte": "^3.1.2",
"svelte": "^4.2.7",
"svelte": "^5.53.5",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major Svelte bump without updating companion tooling packages

High Severity

Bumping svelte from v4 to v5 without updating @sveltejs/vite-plugin-svelte (currently ^3.0.0, needs v5+) and svelte-check (currently ^3.6.0, needs v4+) will likely break the build. Notably, @sveltejs/vite-plugin-svelte@3.1.1 pulls in svelte-hmr@0.16.0, which has a peer dependency of svelte: ^3.19.0 || ^4.0.0 — explicitly excluding Svelte 5. This is a major version migration that requires coordinated upgrades of the entire Svelte tooling ecosystem.

Additional Locations (1)

Fix in Cursor Fix in Web

"svelte-check": "^3.6.0",
"tslib": "^2.4.1",
"typescript": "^5.0.0",
Comment on lines 25 to 31
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The svelte package was upgraded to v5, but its dependencies @sveltejs/kit and @sveltejs/vite-plugin-svelte were not, creating incompatible peer dependencies that will cause build failures.
Severity: CRITICAL

Suggested Fix

To resolve the incompatibility, either revert the svelte package upgrade back to a 4.x version, or upgrade both @sveltejs/kit to a version compatible with Svelte 5 (like SvelteKit 3) and @sveltejs/vite-plugin-svelte to version 4.x or higher.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: apps/sveltekit-2/package.json#L25-L31

Potential issue: The `svelte` dependency was upgraded from version 4 to 5, but related
packages `@sveltejs/kit` (at `^2.0.0`) and `@sveltejs/vite-plugin-svelte` (at `^3.0.0`)
were not updated. SvelteKit 2.x is officially compatible with Svelte 4.x, not Svelte 5.
Furthermore, `@sveltejs/vite-plugin-svelte` version 3.x is designed for Svelte 4, while
Svelte 5 requires version 4.x of the plugin. This version mismatch will cause peer
dependency conflicts, which will prevent the application from building or running
correctly.

Did we get this right? 👍 / 👎 to inform future reviews.

Expand Down
160 changes: 122 additions & 38 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ __metadata:
version: 8
cacheKey: 10c0

"@ampproject/remapping@npm:^2.2.0, @ampproject/remapping@npm:^2.2.1":
"@ampproject/remapping@npm:^2.2.0":
version: 2.3.0
resolution: "@ampproject/remapping@npm:2.3.0"
dependencies:
Expand Down Expand Up @@ -2542,6 +2542,16 @@ __metadata:
languageName: node
linkType: hard

"@jridgewell/remapping@npm:^2.3.4":
version: 2.3.5
resolution: "@jridgewell/remapping@npm:2.3.5"
dependencies:
"@jridgewell/gen-mapping": "npm:^0.3.5"
"@jridgewell/trace-mapping": "npm:^0.3.24"
checksum: 10c0/3de494219ffeb2c5c38711d0d7bb128097edf91893090a2dbc8ee0b55d092bb7347b1fd0f478486c5eab010e855c73927b1666f2107516d472d24a73017d1194
languageName: node
linkType: hard

"@jridgewell/resolve-uri@npm:^3.0.3, @jridgewell/resolve-uri@npm:^3.1.0":
version: 3.1.2
resolution: "@jridgewell/resolve-uri@npm:3.1.2"
Expand Down Expand Up @@ -2573,6 +2583,13 @@ __metadata:
languageName: node
linkType: hard

"@jridgewell/sourcemap-codec@npm:^1.5.0, @jridgewell/sourcemap-codec@npm:^1.5.5":
version: 1.5.5
resolution: "@jridgewell/sourcemap-codec@npm:1.5.5"
checksum: 10c0/f9e538f302b63c0ebc06eecb1dd9918dd4289ed36147a0ddce35d6ea4d7ebbda243cda7b2213b6a5e1d8087a298d5cf630fb2bd39329cdecb82017023f6081a0
languageName: node
linkType: hard

"@jridgewell/trace-mapping@npm:0.3.9":
version: 0.3.9
resolution: "@jridgewell/trace-mapping@npm:0.3.9"
Expand All @@ -2583,7 +2600,7 @@ __metadata:
languageName: node
linkType: hard

"@jridgewell/trace-mapping@npm:^0.3.17, @jridgewell/trace-mapping@npm:^0.3.18, @jridgewell/trace-mapping@npm:^0.3.20, @jridgewell/trace-mapping@npm:^0.3.24, @jridgewell/trace-mapping@npm:^0.3.25":
"@jridgewell/trace-mapping@npm:^0.3.17, @jridgewell/trace-mapping@npm:^0.3.20, @jridgewell/trace-mapping@npm:^0.3.24, @jridgewell/trace-mapping@npm:^0.3.25":
version: 0.3.25
resolution: "@jridgewell/trace-mapping@npm:0.3.25"
dependencies:
Expand Down Expand Up @@ -5687,6 +5704,15 @@ __metadata:
languageName: node
linkType: hard

"@sveltejs/acorn-typescript@npm:^1.0.5":
version: 1.0.9
resolution: "@sveltejs/acorn-typescript@npm:1.0.9"
peerDependencies:
acorn: ^8.9.0
checksum: 10c0/3b39f4ba0d364cc510061acbd5ea3cf45bb07478c7a4d34888d0bf6b5b558b9165f425c8840a280b5494feb2b7f213bb4cc0be743b8f1e31976fe2e05518b55a
languageName: node
linkType: hard

"@sveltejs/adapter-auto@npm:^3.0.0":
version: 3.2.2
resolution: "@sveltejs/adapter-auto@npm:3.2.2"
Expand Down Expand Up @@ -5977,7 +6003,7 @@ __metadata:
languageName: node
linkType: hard

"@types/estree@npm:*, @types/estree@npm:1.0.5, @types/estree@npm:^1.0.0, @types/estree@npm:^1.0.1, @types/estree@npm:^1.0.5":
"@types/estree@npm:*, @types/estree@npm:1.0.5, @types/estree@npm:^1.0.0, @types/estree@npm:^1.0.5":
version: 1.0.5
resolution: "@types/estree@npm:1.0.5"
checksum: 10c0/b3b0e334288ddb407c7b3357ca67dbee75ee22db242ca7c56fe27db4e1a31989cb8af48a84dd401deb787fe10cc6b2ab1ee82dc4783be87ededbe3d53c79c70d
Expand All @@ -5991,6 +6017,13 @@ __metadata:
languageName: node
linkType: hard

"@types/estree@npm:^1.0.6":
version: 1.0.8
resolution: "@types/estree@npm:1.0.8"
checksum: 10c0/39d34d1afaa338ab9763f37ad6066e3f349444f9052b9676a7cc0252ef9485a41c6d81c9c4e0d26e9077993354edf25efc853f3224dd4b447175ef62bdcc86a5
languageName: node
linkType: hard

"@types/express-serve-static-core@npm:^4.17.33":
version: 4.19.5
resolution: "@types/express-serve-static-core@npm:4.19.5"
Expand Down Expand Up @@ -6416,6 +6449,13 @@ __metadata:
languageName: node
linkType: hard

"@types/trusted-types@npm:^2.0.7":
version: 2.0.7
resolution: "@types/trusted-types@npm:2.0.7"
checksum: 10c0/4c4855f10de7c6c135e0d32ce462419d8abbbc33713b31d294596c0cc34ae1fa6112a2f9da729c8f7a20707782b0d69da3b1f8df6645b0366d08825ca1522e0c
languageName: node
linkType: hard

"@types/unist@npm:*, @types/unist@npm:^3.0.0":
version: 3.0.2
resolution: "@types/unist@npm:3.0.2"
Expand Down Expand Up @@ -7415,7 +7455,7 @@ __metadata:
languageName: node
linkType: hard

"acorn@npm:8.12.1, acorn@npm:^8.0.0, acorn@npm:^8.10.0, acorn@npm:^8.11.0, acorn@npm:^8.11.3, acorn@npm:^8.12.0, acorn@npm:^8.12.1, acorn@npm:^8.4.1, acorn@npm:^8.6.0, acorn@npm:^8.7.1, acorn@npm:^8.8.1, acorn@npm:^8.8.2, acorn@npm:^8.9.0":
"acorn@npm:8.12.1, acorn@npm:^8.0.0, acorn@npm:^8.11.0, acorn@npm:^8.11.3, acorn@npm:^8.12.0, acorn@npm:^8.12.1, acorn@npm:^8.4.1, acorn@npm:^8.6.0, acorn@npm:^8.7.1, acorn@npm:^8.8.1, acorn@npm:^8.8.2, acorn@npm:^8.9.0":
version: 8.12.1
resolution: "acorn@npm:8.12.1"
bin:
Expand Down Expand Up @@ -7692,6 +7732,13 @@ __metadata:
languageName: node
linkType: hard

"aria-query@npm:5.3.1":
version: 5.3.1
resolution: "aria-query@npm:5.3.1"
checksum: 10c0/2e9aca7d92d20b8539ee58fa1d29ba07e2269a68da8d27e9830d3cb816d49bb01648610ac3f2e365a8dedbf00168ac18c017ea49c512fbe2537a0b17184a458b
languageName: node
linkType: hard

"aria-query@npm:^5.3.0":
version: 5.3.0
resolution: "aria-query@npm:5.3.0"
Expand Down Expand Up @@ -8051,7 +8098,7 @@ __metadata:
languageName: node
linkType: hard

"axobject-query@npm:^4.0.0, axobject-query@npm:^4.1.0":
"axobject-query@npm:^4.1.0":
version: 4.1.0
resolution: "axobject-query@npm:4.1.0"
checksum: 10c0/c470e4f95008f232eadd755b018cb55f16c03ccf39c027b941cd8820ac6b68707ce5d7368a46756db4256fbc91bb4ead368f84f7fb034b2b7932f082f6dc0775
Expand Down Expand Up @@ -8764,19 +8811,6 @@ __metadata:
languageName: node
linkType: hard

"code-red@npm:^1.0.3":
version: 1.0.4
resolution: "code-red@npm:1.0.4"
dependencies:
"@jridgewell/sourcemap-codec": "npm:^1.4.15"
"@types/estree": "npm:^1.0.1"
acorn: "npm:^8.10.0"
estree-walker: "npm:^3.0.3"
periscopic: "npm:^3.1.0"
checksum: 10c0/1309f062369ae520c422d7f45b93190faea2cbc7e3fe3375918f36bb394030d0936d940601426564c30abc71b8aa8e6d1505cccd67a8620183fb01c84bcb7304
languageName: node
linkType: hard

"color-convert@npm:^1.9.0, color-convert@npm:^1.9.3":
version: 1.9.3
resolution: "color-convert@npm:1.9.3"
Expand Down Expand Up @@ -9737,6 +9771,13 @@ __metadata:
languageName: node
linkType: hard

"devalue@npm:^5.6.3":
version: 5.6.3
resolution: "devalue@npm:5.6.3"
checksum: 10c0/701fbe57b9b8b71cf5f9e706a6c977cffadd5083298e442d460e82f04480b8c5656aa3c6eb36aed33b387f4266aed6abd2143cd91e94f96931302225d14789ba
languageName: node
linkType: hard

"devlop@npm:^1.0.0, devlop@npm:^1.1.0":
version: 1.1.0
resolution: "devlop@npm:1.1.0"
Expand Down Expand Up @@ -11045,6 +11086,13 @@ __metadata:
languageName: node
linkType: hard

"esm-env@npm:^1.2.1":
version: 1.2.2
resolution: "esm-env@npm:1.2.2"
checksum: 10c0/3d25c973f2fd69c25ffff29c964399cea573fe10795ecc1d26f6f957ce0483d3254e1cceddb34bf3296a0d7b0f1d53a28992f064ba509dfe6366751e752c4166
languageName: node
linkType: hard

"espree@npm:^10.0.1, espree@npm:^10.1.0":
version: 10.1.0
resolution: "espree@npm:10.1.0"
Expand Down Expand Up @@ -11086,6 +11134,15 @@ __metadata:
languageName: node
linkType: hard

"esrap@npm:^2.2.2":
version: 2.2.3
resolution: "esrap@npm:2.2.3"
dependencies:
"@jridgewell/sourcemap-codec": "npm:^1.4.15"
checksum: 10c0/6eda59f9968e52b9b150dec0cb8acf2f42fef62b16918cefb64d25e5aeaa969cf44ca2a6260b14994cb7e5ac2e78ab8170158339901ab0e913c52f780891ab95
languageName: node
linkType: hard

"esrecurse@npm:^4.3.0":
version: 4.3.0
resolution: "esrecurse@npm:4.3.0"
Expand Down Expand Up @@ -13471,7 +13528,7 @@ __metadata:
languageName: node
linkType: hard

"is-reference@npm:^3.0.0, is-reference@npm:^3.0.1":
"is-reference@npm:^3.0.0":
version: 3.0.2
resolution: "is-reference@npm:3.0.2"
dependencies:
Expand All @@ -13480,6 +13537,15 @@ __metadata:
languageName: node
linkType: hard

"is-reference@npm:^3.0.3":
version: 3.0.3
resolution: "is-reference@npm:3.0.3"
dependencies:
"@types/estree": "npm:^1.0.6"
checksum: 10c0/35edd284cfb4cd9e9f08973f20e276ec517eaca31f5f049598e97dbb2d05544973dde212dac30fddee5b420930bff365e2e67dcd1293d0866c6720377382e3e5
languageName: node
linkType: hard

"is-regex@npm:^1.1.4":
version: 1.1.4
resolution: "is-regex@npm:1.1.4"
Expand Down Expand Up @@ -14467,6 +14533,15 @@ __metadata:
languageName: node
linkType: hard

"magic-string@npm:^0.30.11":
version: 0.30.21
resolution: "magic-string@npm:0.30.21"
dependencies:
"@jridgewell/sourcemap-codec": "npm:^1.5.5"
checksum: 10c0/299378e38f9a270069fc62358522ddfb44e94244baa0d6a8980ab2a9b2490a1d03b236b447eee309e17eb3bddfa482c61259d47960eb018a904f0ded52780c4a
languageName: node
linkType: hard

"magicast@npm:0.2.8":
version: 0.2.8
resolution: "magicast@npm:0.2.8"
Expand Down Expand Up @@ -17397,7 +17472,7 @@ __metadata:
languageName: node
linkType: hard

"periscopic@npm:^3.0.0, periscopic@npm:^3.1.0":
"periscopic@npm:^3.0.0":
version: 3.1.0
resolution: "periscopic@npm:3.1.0"
dependencies:
Expand Down Expand Up @@ -20657,25 +20732,27 @@ __metadata:
languageName: node
linkType: hard

"svelte@npm:^4.2.7":
version: 4.2.18
resolution: "svelte@npm:4.2.18"
"svelte@npm:^5.53.5":
version: 5.53.6
resolution: "svelte@npm:5.53.6"
dependencies:
"@ampproject/remapping": "npm:^2.2.1"
"@jridgewell/sourcemap-codec": "npm:^1.4.15"
"@jridgewell/trace-mapping": "npm:^0.3.18"
"@types/estree": "npm:^1.0.1"
acorn: "npm:^8.9.0"
aria-query: "npm:^5.3.0"
axobject-query: "npm:^4.0.0"
code-red: "npm:^1.0.3"
css-tree: "npm:^2.3.1"
estree-walker: "npm:^3.0.3"
is-reference: "npm:^3.0.1"
"@jridgewell/remapping": "npm:^2.3.4"
"@jridgewell/sourcemap-codec": "npm:^1.5.0"
"@sveltejs/acorn-typescript": "npm:^1.0.5"
"@types/estree": "npm:^1.0.5"
"@types/trusted-types": "npm:^2.0.7"
acorn: "npm:^8.12.1"
aria-query: "npm:5.3.1"
axobject-query: "npm:^4.1.0"
clsx: "npm:^2.1.1"
devalue: "npm:^5.6.3"
esm-env: "npm:^1.2.1"
esrap: "npm:^2.2.2"
is-reference: "npm:^3.0.3"
locate-character: "npm:^3.0.0"
magic-string: "npm:^0.30.4"
periscopic: "npm:^3.1.0"
checksum: 10c0/33cb321b59d0d29730f44054e442adcfdb6f6b51968c60e4027a2d2aa59cba2e2360aa42b4c61b0223350eacfe8dbeb3b724476d03fffb89a3c87021edbb1562
magic-string: "npm:^0.30.11"
zimmerframe: "npm:^1.1.2"
checksum: 10c0/e49a586a17283988ba341de16507e92eb43127950762c33543d28f96d148048d6b01fccae89764e9ad3f199dbdbd19493b20df709e1ae759b9a51e6ba60132af
languageName: node
linkType: hard

Expand All @@ -20695,7 +20772,7 @@ __metadata:
eslint-plugin-svelte: "npm:^2.35.1"
prettier: "npm:^3.1.1"
prettier-plugin-svelte: "npm:^3.1.2"
svelte: "npm:^4.2.7"
svelte: "npm:^5.53.5"
svelte-check: "npm:^3.6.0"
tslib: "npm:^2.4.1"
typescript: "npm:^5.0.0"
Expand Down Expand Up @@ -23168,6 +23245,13 @@ __metadata:
languageName: node
linkType: hard

"zimmerframe@npm:^1.1.2":
version: 1.1.4
resolution: "zimmerframe@npm:1.1.4"
checksum: 10c0/9470cbf22cefae975ab413c7158a119d082b354ddcf0da48a842f2f42246fa15943cd9b92c047de39db38015e3b866e32f383bc217e8e4f4192945c7d425536b
languageName: node
linkType: hard

"zip-stream@npm:^6.0.1":
version: 6.0.1
resolution: "zip-stream@npm:6.0.1"
Expand Down
Loading