Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/astro/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"dependencies": {
"@astrojs/check": "^0.5.10",
"@astrojs/node": "^8.2.5",
"@astrojs/node": "^9.5.4",
"@sentry/astro": "8.9.2",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The update to @astrojs/node@9.5.4 introduces a peer dependency on astro@^5.17.3, but the project's astro version remains at ^4.7.0, causing an incompatibility.
Severity: CRITICAL

Suggested Fix

Update the astro dependency in package.json to a version compatible with @astrojs/node@9.5.4, such as ^5.17.3. Also, address any breaking changes from the Astro v5 upgrade, like the output: 'hybrid' configuration which is no longer supported.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: apps/astro/package.json#L15

Potential issue: The project's `package.json` specifies `astro: ^4.7.0`, but the newly
updated `@astrojs/node` package (`9.5.4`) requires `astro: ^5.17.3` as a peer
dependency. This major version mismatch will cause a runtime failure. While `yarn
install` will complete with a warning, the application build will fail when the
`@astrojs/node` adapter attempts to use APIs specific to Astro v5 that are not available
in the installed Astro v4. This will prevent the application from being built and
deployed.

Did we get this right? 👍 / 👎 to inform future reviews.

"astro": "^4.7.0",
"typescript": "^5.4.5"
Expand Down
115 changes: 102 additions & 13 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,13 @@ __metadata:
languageName: node
linkType: hard

"@astrojs/internal-helpers@npm:0.7.5":
version: 0.7.5
resolution: "@astrojs/internal-helpers@npm:0.7.5"
checksum: 10c0/cbe9fddae3c2d5c85c1223723da78cf77978f5c98087ed4bfeb4ee2d69f50a8cd284bc07f5ab384b82552bc3a41cd49d757f93b5aee90e9d2b910bdd5d4139f7
languageName: node
linkType: hard

"@astrojs/language-server@npm:^2.8.4":
version: 2.12.1
resolution: "@astrojs/language-server@npm:2.12.1"
Expand Down Expand Up @@ -194,15 +201,16 @@ __metadata:
languageName: node
linkType: hard

"@astrojs/node@npm:^8.2.5":
version: 8.3.2
resolution: "@astrojs/node@npm:8.3.2"
"@astrojs/node@npm:^9.5.4":
version: 9.5.4
resolution: "@astrojs/node@npm:9.5.4"
dependencies:
send: "npm:^0.18.0"
"@astrojs/internal-helpers": "npm:0.7.5"
send: "npm:^1.2.1"
server-destroy: "npm:^1.0.1"
peerDependencies:
astro: ^4.2.0
checksum: 10c0/264059384c4f7ff20f80a923c37eb83a3a924a597c5401ca0afbe7760a59d0d4a865af234e2def0c958fbd7749b039e66a2c06b63dc83725dca8eb49fd4d24bc
astro: ^5.17.3
checksum: 10c0/90491c18fd0658c2f7e3104b2750244d1fe879a85d32f60a7b1b7bf6d4301e79bd657c17ec8b946c7e351648c514332cb75062b876575bc4de07255c47a327ac
languageName: node
linkType: hard

Expand Down Expand Up @@ -7903,7 +7911,7 @@ __metadata:
resolution: "astro-test-application@workspace:apps/astro"
dependencies:
"@astrojs/check": "npm:^0.5.10"
"@astrojs/node": "npm:^8.2.5"
"@astrojs/node": "npm:^9.5.4"
"@sentry/astro": "npm:8.9.2"
astro: "npm:^4.7.0"
typescript: "npm:^5.4.5"
Expand Down Expand Up @@ -9498,6 +9506,18 @@ __metadata:
languageName: node
linkType: hard

"debug@npm:^4.4.3":
version: 4.4.3
resolution: "debug@npm:4.4.3"
dependencies:
ms: "npm:^2.1.3"
peerDependenciesMeta:
supports-color:
optional: true
checksum: 10c0/d79136ec6c83ecbefd0f6a5593da6a9c91ec4d7ddc4b54c883d6e71ec9accb5f67a1a5e96d00a328196b5b5c86d365e98d8a3a70856aaf16b4e7b1985e67f5a6
languageName: node
linkType: hard

"decode-named-character-reference@npm:^1.0.0":
version: 1.0.2
resolution: "decode-named-character-reference@npm:1.0.2"
Expand Down Expand Up @@ -9940,6 +9960,13 @@ __metadata:
languageName: node
linkType: hard

"encodeurl@npm:^2.0.0":
version: 2.0.0
resolution: "encodeurl@npm:2.0.0"
checksum: 10c0/5d317306acb13e6590e28e27924c754163946a2480de11865c991a3a7eed4315cd3fba378b543ca145829569eefe9b899f3d84bb09870f675ae60bc924b01ceb
languageName: node
linkType: hard

"encoding@npm:^0.1.13":
version: 0.1.13
resolution: "encoding@npm:0.1.13"
Expand Down Expand Up @@ -11845,6 +11872,13 @@ __metadata:
languageName: node
linkType: hard

"fresh@npm:^2.0.0":
version: 2.0.0
resolution: "fresh@npm:2.0.0"
checksum: 10c0/0557548194cb9a809a435bf92bcfbc20c89e8b5eb38861b73ced36750437251e39a111fc3a18b98531be9dd91fe1411e4969f229dc579ec0251ce6c5d4900bbc
languageName: node
linkType: hard

"fs-constants@npm:^1.0.0":
version: 1.0.0
resolution: "fs-constants@npm:1.0.0"
Expand Down Expand Up @@ -12738,6 +12772,19 @@ __metadata:
languageName: node
linkType: hard

"http-errors@npm:^2.0.1":
version: 2.0.1
resolution: "http-errors@npm:2.0.1"
dependencies:
depd: "npm:~2.0.0"
inherits: "npm:~2.0.4"
setprototypeof: "npm:~1.2.0"
statuses: "npm:~2.0.2"
toidentifier: "npm:~1.0.1"
checksum: 10c0/fb38906cef4f5c83952d97661fe14dc156cb59fe54812a42cd448fa57b5c5dfcb38a40a916957737bd6b87aab257c0648d63eb5b6a9ca9f548e105b6072712d4
languageName: node
linkType: hard

"http-proxy-agent@npm:^7.0.0":
version: 7.0.2
resolution: "http-proxy-agent@npm:7.0.2"
Expand Down Expand Up @@ -12971,7 +13018,7 @@ __metadata:
languageName: node
linkType: hard

"inherits@npm:2, inherits@npm:2.0.4, inherits@npm:^2.0.1, inherits@npm:^2.0.3, inherits@npm:^2.0.4, inherits@npm:~2.0.3":
"inherits@npm:2, inherits@npm:2.0.4, inherits@npm:^2.0.1, inherits@npm:^2.0.3, inherits@npm:^2.0.4, inherits@npm:~2.0.3, inherits@npm:~2.0.4":
version: 2.0.4
resolution: "inherits@npm:2.0.4"
checksum: 10c0/4e531f648b29039fb7426fb94075e6545faa1eb9fe83c29f0b6d9e7263aceb4289d2d4557db0d428188eeb449cc7c5e77b0a0b2c4e248ff2a65933a0dee49ef2
Expand Down Expand Up @@ -15646,6 +15693,13 @@ __metadata:
languageName: node
linkType: hard

"mime-db@npm:^1.54.0":
version: 1.54.0
resolution: "mime-db@npm:1.54.0"
checksum: 10c0/8d907917bc2a90fa2df842cdf5dfeaf509adc15fe0531e07bb2f6ab15992416479015828d6a74200041c492e42cce3ebf78e5ce714388a0a538ea9c53eece284
languageName: node
linkType: hard

"mime-types@npm:^2.1.18, mime-types@npm:^2.1.27, mime-types@npm:~2.1.24, mime-types@npm:~2.1.34":
version: 2.1.35
resolution: "mime-types@npm:2.1.35"
Expand All @@ -15655,6 +15709,15 @@ __metadata:
languageName: node
linkType: hard

"mime-types@npm:^3.0.2":
version: 3.0.2
resolution: "mime-types@npm:3.0.2"
dependencies:
mime-db: "npm:^1.54.0"
checksum: 10c0/35a0dd1035d14d185664f346efcdb72e93ef7a9b6e9ae808bd1f6358227010267fab52657b37562c80fc888ff76becb2b2938deb5e730818b7983bf8bd359767
languageName: node
linkType: hard

"mime@npm:1.6.0":
version: 1.6.0
resolution: "mime@npm:1.6.0"
Expand Down Expand Up @@ -16866,7 +16929,7 @@ __metadata:
languageName: node
linkType: hard

"on-finished@npm:2.4.1, on-finished@npm:^2.3.0":
"on-finished@npm:2.4.1, on-finished@npm:^2.3.0, on-finished@npm:^2.4.1":
version: 2.4.1
resolution: "on-finished@npm:2.4.1"
dependencies:
Expand Down Expand Up @@ -18427,7 +18490,7 @@ __metadata:
languageName: node
linkType: hard

"range-parser@npm:~1.2.1":
"range-parser@npm:^1.2.1, range-parser@npm:~1.2.1":
version: 1.2.1
resolution: "range-parser@npm:1.2.1"
checksum: 10c0/96c032ac2475c8027b7a4e9fe22dc0dfe0f6d90b85e496e0f016fbdb99d6d066de0112e680805075bd989905e2123b3b3d002765149294dce0c1f7f01fcc2ea0
Expand Down Expand Up @@ -19606,7 +19669,7 @@ __metadata:
languageName: node
linkType: hard

"send@npm:0.18.0, send@npm:^0.18.0":
"send@npm:0.18.0":
version: 0.18.0
resolution: "send@npm:0.18.0"
dependencies:
Expand All @@ -19627,6 +19690,25 @@ __metadata:
languageName: node
linkType: hard

"send@npm:^1.2.1":
version: 1.2.1
resolution: "send@npm:1.2.1"
dependencies:
debug: "npm:^4.4.3"
encodeurl: "npm:^2.0.0"
escape-html: "npm:^1.0.3"
etag: "npm:^1.8.1"
fresh: "npm:^2.0.0"
http-errors: "npm:^2.0.1"
mime-types: "npm:^3.0.2"
ms: "npm:^2.1.3"
on-finished: "npm:^2.4.1"
range-parser: "npm:^1.2.1"
statuses: "npm:^2.0.2"
checksum: 10c0/fbbbbdc902a913d65605274be23f3d604065cfc3ee3d78bf9fc8af1dc9fc82667c50d3d657f5e601ac657bac9b396b50ee97bd29cd55436320cf1cddebdcec72
languageName: node
linkType: hard

"sentry-javascript-examples@workspace:.":
version: 0.0.0-use.local
resolution: "sentry-javascript-examples@workspace:."
Expand Down Expand Up @@ -19724,7 +19806,7 @@ __metadata:
languageName: node
linkType: hard

"setprototypeof@npm:1.2.0":
"setprototypeof@npm:1.2.0, setprototypeof@npm:~1.2.0":
version: 1.2.0
resolution: "setprototypeof@npm:1.2.0"
checksum: 10c0/68733173026766fa0d9ecaeb07f0483f4c2dc70ca376b3b7c40b7cda909f94b0918f6c5ad5ce27a9160bdfb475efaa9d5e705a11d8eaae18f9835d20976028bc
Expand Down Expand Up @@ -20195,6 +20277,13 @@ __metadata:
languageName: node
linkType: hard

"statuses@npm:^2.0.2, statuses@npm:~2.0.2":
version: 2.0.2
resolution: "statuses@npm:2.0.2"
checksum: 10c0/a9947d98ad60d01f6b26727570f3bcceb6c8fa789da64fe6889908fe2e294d57503b14bf2b5af7605c2d36647259e856635cd4c49eab41667658ec9d0080ec3f
languageName: node
linkType: hard

"std-env@npm:^3.7.0":
version: 3.7.0
resolution: "std-env@npm:3.7.0"
Expand Down Expand Up @@ -20939,7 +21028,7 @@ __metadata:
languageName: node
linkType: hard

"toidentifier@npm:1.0.1":
"toidentifier@npm:1.0.1, toidentifier@npm:~1.0.1":
version: 1.0.1
resolution: "toidentifier@npm:1.0.1"
checksum: 10c0/93937279934bd66cc3270016dd8d0afec14fb7c94a05c72dc57321f8bd1fa97e5bea6d1f7c89e728d077ca31ea125b78320a616a6c6cd0e6b9cb94cb864381c1
Expand Down
Loading