Closed
Conversation
Bumps [svelte](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte) from 4.2.18 to 5.51.5. - [Release notes](https://github.com/sveltejs/svelte/releases) - [Changelog](https://github.com/sveltejs/svelte/blob/main/packages/svelte/CHANGELOG.md) - [Commits](https://github.com/sveltejs/svelte/commits/svelte@5.51.5/packages/svelte) --- updated-dependencies: - dependency-name: svelte dependency-version: 5.51.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "prettier": "^3.1.1", | ||
| "prettier-plugin-svelte": "^3.1.2", | ||
| "svelte": "^4.2.7", | ||
| "svelte": "^5.51.5", |
There was a problem hiding this comment.
Bug: The application upgrades to Svelte 5 but keeps @sentry/sveltekit at v8.9.2, a version not compatible with Svelte 5's new architecture, which will likely break runtime error tracking.
Severity: HIGH
Suggested Fix
The @sentry/sveltekit package should be upgraded to a version that officially supports Svelte 5. Check the Sentry documentation or release notes for the correct version compatible with Svelte 5 and update the package.json dependency accordingly.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: apps/sveltekit-2/package.json#L28
Potential issue: The upgrade to Svelte 5 introduces significant architectural changes,
such as components being functions instead of classes and the removal of internal APIs
like `current_component`. The existing `@sentry/sveltekit` version 8.9.2 relies on the
Svelte 4 architecture and its internal APIs. This incompatibility will likely cause the
Sentry integration to fail at runtime. Specifically, the `sentrySvelteKit()` Vite plugin
may fail to instrument components correctly, and client-side error tracking via
`handleErrorWithSentry` may break silently or lose crucial context, defeating the
purpose of the error monitoring.
Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
Author
|
Superseded by #52. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps svelte from 4.2.18 to 5.51.5.
Release notes
Sourced from svelte's releases.
... (truncated)
Changelog
Sourced from svelte's changelog.
... (truncated)
Commits
8ea33bfVersion Packages (#17740)f855a0bfix: misc option escaping and backwards compatibility (#17741)781052echore: upgradedevalue(#17739)f7c80daMerge commit from forka0c7f28Merge commit from fork73098bbMerge commit from forkf89c7ddMerge commit from forkb8f2b86Version Packages (#17733)c83aa06chore: proactively defer effects in pending boundary (#17734)2287ad0fix: detect and error on non-idempotent each block keys in dev mode (#17732)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for svelte since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.