perf(android): Use generated manifest metadata - #5969
Draft
romtsn wants to merge 4 commits into
Draft
Conversation
Allow the Android Gradle plugin to provide authoritative manifest metadata so SDK initialization can skip PackageManager and Bundle unparceling. Read the injected map directly to avoid conversion overhead. Refs JAVA-531 Co-Authored-By: Codex <noreply@openai.com>
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc5ccaf | 276.52 ms | 370.46 ms | 93.93 ms |
| fcec2f2 | 314.96 ms | 373.66 ms | 58.70 ms |
| 70118e9 | 380.00 ms | 475.72 ms | 95.72 ms |
| f634d01 | 359.58 ms | 433.88 ms | 74.30 ms |
| f064536 | 349.86 ms | 417.66 ms | 67.80 ms |
| 0eaac1e | 322.53 ms | 389.31 ms | 66.78 ms |
| 32811a3 | 313.16 ms | 366.22 ms | 53.06 ms |
| 5865051 | 333.08 ms | 355.34 ms | 22.26 ms |
| 65aff4f | 323.59 ms | 370.71 ms | 47.12 ms |
| 3998a95 | 415.94 ms | 478.54 ms | 62.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| 70118e9 | 1.58 MiB | 2.29 MiB | 719.84 KiB |
| f634d01 | 1.58 MiB | 2.10 MiB | 533.40 KiB |
| f064536 | 1.58 MiB | 2.20 MiB | 633.90 KiB |
| 0eaac1e | 1.58 MiB | 2.19 MiB | 619.17 KiB |
| 32811a3 | 0 B | 0 B | 0 B |
| 5865051 | 0 B | 0 B | 0 B |
| 65aff4f | 0 B | 0 B | 0 B |
| 3998a95 | 1.58 MiB | 2.10 MiB | 532.96 KiB |
…ed-manifest-metadata # Conflicts: # CHANGELOG.md
runningcode
reviewed
Aug 14, 2026
|
|
||
| // Populated by the Sentry Android Gradle plugin with manifest metadata resolved at build time. | ||
| // When set, it is authoritative: the manifest is not read at runtime. | ||
| static @Nullable Map<String, Object> buildTimeMetadata; |
Contributor
There was a problem hiding this comment.
I wonder if we should separate the data to a separate class that just holds the data. That would make refactorings of ManifestMetadataReader easier and separate the "reading" from the "data" holder concern.
Keep the Gradle plugin bytecode contract separate from manifest reader implementation details. Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Use manifest metadata injected by the Sentry Android Gradle plugin when available. The existing PackageManager Bundle remains the fallback, and all existing runtime option precedence remains unchanged.
💡 Motivation and Context
Reading ApplicationInfo metadata and converting every manifest option during startup showed up prominently in customer traces. The paired plugin change in getsentry/sentry-android-gradle-plugin#1405 resolves typed metadata from the final merged manifest and avoids that runtime work, reducing median SDK initialization time by 6.5% in the all-options benchmark.
💚 How did you test it?
Ran the ManifestMetadataReader release unit tests, including typed generated values, absent keys, auto-init, PackageManager fallback, and no Context access on the generated path. Also ran spotlessApply and apiDump.
📝 Checklist
🔮 Next steps
Release with getsentry/sentry-android-gradle-plugin#1405 to enable the generated path.