test(sql): add fakedriver#1283
Open
giortzisg wants to merge 2 commits into
Open
Conversation
giortzisg
force-pushed
the
test/add-sql-fakedriver
branch
from
206ff13 to
2367f4f
Compare
giortzisg
force-pushed
the
test/add-sql-fakedriver
branch
from
2367f4f to
1e6d1b6
Compare
sl0thentr0py
approved these changes
May 20, 2026
| // the internal ctxConnector returned by CtxDriver.OpenConnector, this one | ||
| // implements io.Closer with an observable close counter so tests can verify | ||
| // that the sentrysql wrapper propagates DB.Close through to inner connectors. | ||
| type CtxConnector struct { |
Member
There was a problem hiding this comment.
the naming of ctxConnector vs CtxConnector is very opaque, maybe call it CtxConnectorWithCount or CtxConnectorWithClose
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a mock fakedriver for the sql integration. The driver exposes minimal, legacy and full driver implementations for testing various code paths of the integration.
#skip-changelog
Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)