fix(client): Ignore Algolia Insights NetworkError from Firefox ETP - #19046
Open
sentry[bot] wants to merge 1 commit into
Open
fix(client): Ignore Algolia Insights NetworkError from Firefox ETP#19046sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ignoreErrors: [/__firefox__/, /DarkReader/], | ||
| // Also ignore NetworkErrors from insights.algolia.io — these are blocked by Firefox's | ||
| // Enhanced Tracking Protection and ad-blockers when Algolia click analytics are fired. | ||
| ignoreErrors: [/__firefox__/, /DarkReader/, /NetworkError.*insights\.algolia\.io/], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
The issue DOCS-B3C reported
TypeError: NetworkError when attempting to fetch resource. (insights.algolia.io). This error occurs when Firefox's Enhanced Tracking Protection (ETP) or similar ad-blockers block the Algolia Insights SDK's click-tracking requests toinsights.algolia.io. This is expected browser privacy behavior and not an application bug. Since the error is handled and harmless, it primarily creates noise in Sentry.This PR adds a regex to the
ignoreErrorsarray insrc/instrumentation-client.tsto filter out these specificNetworkErrorevents originating frominsights.algolia.io. This prevents unnecessary error reporting to Sentry without affecting the functionality of the Algolia integration.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES
Fixes DOCS-B3C